LG-11728 Sign in sign out page for user guide#426
Merged
Conversation
Contributor
|
I'm seeing a big empty box on the page, is this intentional? |
Contributor
Author
@Jeremy1026 yes that is where the embed will be and why I provided screenshots in the description. it won't show up in the federalist environment because of the CSP header |
Contributor
|
Ok cool! Just wanted to be 100% sure. |
Jeremy1026
approved these changes
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final page of the user guide that was blocked because of work on the lookbook embed (see PR here)
Permitted CSP domains for the iframe embed (which lives in the dev domain) are controlled with components_embed_frame_ancestors in the config file. You can also run it locally and update the yml file and the src url of the iframe to see it in action.
See screenshots below for the embed:
Please refer to the Figma file for the mockups of the design
https://www.figma.com/file/3KSAr0qfDv8BXFIHyFEudZ/Login.gov-OIDC%2C-SAML%2C-and-UX-guides-(LG-10262%2C-LG-10514)?type=design&node-id=125-9414&mode=design&t=ltRBs7rU2j7mKW6B-0