GRParmParse: Add default values to the ParmParse table #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The array of bools did not work with some of the ParmParse changes.
When a GRParmParse::load() overload is called and a default value is used as the parameter is not present in the ParmParse table, this default value will now be added to the ParmParse table.
mirenradia
force-pushed
the
enhancement/default_param_pp_table
branch
from
8f607f3
to
1fad2da
Compare
julianakwan
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
GRParmParse::load()overload is called and a default value is used as the parameter is not present in theParmParsetable, this default value will now be added to theParmParsetable.This behaviour is similar to AMReX's
ParmParse::queryAdd()function (which we use to implement as it saves us some boilerplate code) except we continue to print out our default message.It was necessary to change the type of the variable that is used to store the
isPeriodicparameter (temporarily) to get this to work as there doesn't seem to be an overload ofParmParse::queryarr()forstd::arrays ofbools.This is the first very small step to tackling #1.