Pushconstants fixes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikWitczakAMD
suggested changes
Mar 27, 2017
examples/PushConstants/src/app.cpp
Outdated
| @@ -291,7 +291,7 @@ void App::get_luminance_data(std::shared_ptr<float>* out_result_ptr, | |||
|
|
|||
| luminance_data_size = sizeof(float) * N_TRIANGLES; | |||
|
|
|||
| luminance_data_ptr.reset(new float[luminance_data_size / sizeof(float)]); | |||
| luminance_data_ptr.reset(new float[luminance_data_size / sizeof(float)], [](float *data) { delete [] data; }); | |||
There was a problem hiding this comment.
Can you replace the lambda func with a std::default_delete<float[]>() ? Having gone through the pain of enabling the "warings = errors" mode, I'd rather not add new C++11 requirements to the project.
Since the data was allocated with `operator new[]`, it has to be deleted with `operator delete[]` rather than default `delete`
janisozaur
force-pushed
the
pushconstants-fixes
branch
from
cc80ac8 to
846e5cf
Compare
DominikWitczakAMD
added a commit
that referenced
this pull request
Apr 4, 2019
Fix #134: Assertion failure when using specialization constants Address #18: Add CMake option to use alternative glslang snapshot Address #75: Replace in_releaseable_sets wioth descriptor pool create flags in DescriptorSetGroup::create() Address #104: Pipeline cache to use for a particular device can now be specified in DeviceCreateInfo. Address #59: Change add_vertex_attribute() to add_vertex_binding()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for PushConstants example