Added publication show logs link in change view #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
This was referenced Oct 22, 2024
bart-maykin
force-pushed
the
feature/16-log-link-from-admin
branch
from
22c81a8 to
af3c6d6
Compare
This approach is the best of both worlds: * the admin mixin prepares the template context for the change view * the 'change_form_object_tools.html' template override can be global, provided we check for the necessary context from the mixin - that way we only have a very minimal snippet of template code that needs to be overridden * we don't need provide app/model specific template overrides, nor do we need to specify a custom template to use for the change_view
| @@ -58,10 +58,15 @@ def log_deletion(self, request, object, object_repr): | |||
|
|
|||
| return super().log_deletion(request, object, object_repr) # type: ignore reportAttributeAccessIssue | |||
|
|
|||
| def change_view(self, request, object_id, form_url="", extra_context=None): | |||
| def change_view(self, request, object_id, form_url="", extra_context={}): | |||
There was a problem hiding this comment.
mutable defaults are an anti-pattern! See https://www.pythonmorsels.com/mutable-default-arguments/
| TimelineLog.objects.create(extra_data={}) | ||
| TimelineLog.objects.create(extra_data=[]) | ||
|
|
||
| with self.subTest("publications has 'show logs' button and filters correctly"): |
There was a problem hiding this comment.
This is again a test that belongs in the publications app rather than in the logging app - the giveway is that you're importing factories/models from another django app.
However, we can rephrase this test a little bit to make it more "generic" in nature, I will push a commit for that.
sergei-maertens
force-pushed
the
feature/16-log-link-from-admin
branch
from
af3c6d6 to
891a828
Compare
sergei-maertens
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes #16