Add models and admin integration for audit logging #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
|
sergei-maertens
force-pushed
the
feature/16-add-audit-logging
branch
2 times, most recently
from
407c0ea to
3ee603b
Compare
* Added proxy model, which enforces that an event and acting user is
specified in the metadata of the log record. This is not 100% idiot
proof since bulk update queries etc. and direct timeline-logger
usage allows circumventing these. Ideally we'd have some database
constraints, but those can't be specified through a proxy model.
* Added a custom admin integration for the proxy model:
- block writing to log records entirely, even for superusers
- process the event/acting_user structured data to display it as nice
columns
- allow searching on the user details in the admin log page
* Added a custom default message template that can leverage the
metadata constraints that are enforced.
Ensure that the base assumptions and functionality work as expected.
sergei-maertens
force-pushed
the
feature/16-add-audit-logging
branch
2 times, most recently
from
e48c0f4 to
d385ffd
Compare
bart-maykin
approved these changes
Oct 10, 2024
sergei-maertens
force-pushed
the
feature/16-add-audit-logging
branch
from
d385ffd to
759a90c
Compare
log.content_object cannot be prefetch in Django 4.2 (though it looks like 5.2 will have it). To avoid doing a query for each log record on a page in the admin list (100 records -> 100 queries), we can cache the representation and make sure we try the cache first before doing extra queries.
sergei-maertens
force-pushed
the
feature/16-add-audit-logging
branch
from
759a90c to
e797ba5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes #16
Changes
TODO
Preview: