Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose owner/creator of Publicatie and allow filtering #69

Closed
2 tasks done
Tracked by #2
sergei-maertens opened this issue Oct 9, 2024 · 1 comment · Fixed by #103
Closed
2 tasks done
Tracked by #2

Expose owner/creator of Publicatie and allow filtering #69

sergei-maertens opened this issue Oct 9, 2024 · 1 comment · Fixed by #103
Labels
enhancement New feature or request
Milestone
Plateau 0 (MVP)

Comments

@sergei-maertens
Copy link
Contributor

sergei-maertens commented Oct 9, 2024 •
edited by bart-maykin
Loading

Thema / Theme

API

Omschrijving / Description

Filtering the "own" publications in the UI (by the ODPC BFF) requires the filter parameter to exist on our end, and the information to be extracted.

This depends on the #16 and audit logging added via #35 to register the information about "ownership".

Extra field to expose on the Publicatie resource:

eigenaar:
  type: object
  properties:
    weergaveNaam:  # obtained from the audit trail request headers, extracted from the audit trails/log entries
      type: string
    identifier:  # arbitrary, unique-ish string. Could be a `sub` claim from OIDC, but for our perspective this data has no "meaning"
      type: string

Tasks

  • Expose eigenaar field
  • Add filter parameter eigenaar to list API endpoint for Publicatie. The field must be an exact match on eigenaar.identifier.

Toegevoegde waarde / Added value

Being able to finish GPP-Woo/GPP-app#8

Aanvullende opmerkingen / Additional context

No response
@sergei-maertens sergei-maertens added the enhancement New feature or request label Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Backlog in GPP-Woo Oct 9, 2024
@sergei-maertens sergei-maertens added this to the 04. ODRC: Beheren publicaties milestone Oct 9, 2024
@sergei-maertens sergei-maertens moved this from Backlog to Refinement in GPP-Woo Oct 9, 2024
@sergei-maertens
Copy link
Contributor Author

@MarcoKlerks if you have no further remarks, feel free to move this to Ready

@sergei-maertens sergei-maertens mentioned this issue Oct 9, 2024
Closed
11 tasks
@MarcoKlerks MarcoKlerks moved this from Refinement to Ready in GPP-Woo Oct 11, 2024
@nijmra nijmra mentioned this issue Oct 14, 2024
Closed
7 tasks
@MarcoKlerks MarcoKlerks removed their assignment Oct 14, 2024
@bart-maykin bart-maykin self-assigned this Oct 29, 2024
bart-maykin added a commit that referenced this issue Oct 30, 2024
@bart-maykin
✨ [#69] added owner field in the publication api endpoint, and added …
5d34ad3 
…filter to filter on the owners idenifier
@bart-maykin bart-maykin mentioned this issue Oct 30, 2024
Merged
bart-maykin added a commit that referenced this issue Oct 30, 2024
@bart-maykin
✨ [#69] added owner field in the publication api endpoint, and added …
699df9b 
…filter to filter on the owners idenifier
sergei-maertens pushed a commit that referenced this issue Oct 30, 2024
@bart-maykin @sergei-maertens
✨ [#69] added owner field in the publication api endpoint, and added …
12eb915 
…filter to filter on the owners idenifier
bart-maykin added a commit that referenced this issue Oct 30, 2024
@bart-maykin
✨ [#69] added owner field in the publication api endpoint, and added …
56dcc4d 
…filter to filter on the owners idenifier
bart-maykin added a commit that referenced this issue Oct 30, 2024
@bart-maykin
🎨 [#69] changed SerializerMethodField to EigenaarSerializer for publi…
eb24343 
…cation serializer. Added get_owner method for the Publication model to use in conjunction with the EigenaarSerializer. And changed the way we retrieve the ContentType in filter_eigenaar method from the PublicationFilterset.
bart-maykin added a commit that referenced this issue Oct 31, 2024
@bart-maykin
🎨 [#69] changed SerializerMethodField to EigenaarSerializer for publi…
f781169 
…cation serializer. Added get_owner method for the Publication model to use in conjunction with the EigenaarSerializer. And changed the way we retrieve the ContentType in filter_eigenaar method from the PublicationFilterset.
@github-project-automation github-project-automation bot moved this from In review to Done in GPP-Woo Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in GPP-Woo Nov 1, 2024
@sergei-maertens sergei-maertens moved this from In progress to In review in GPP-Woo Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Testing to Done in GPP-Woo Nov 1, 2024
@MarcoKlerks MarcoKlerks removed their assignment Dec 16, 2024
@MarcoKlerks MarcoKlerks added this to the Plateau 0 (MVP) milestone Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
GPP-Woo
Status: Done
Milestone
Plateau 0 (MVP)
Development

Successfully merging a pull request may close this issue.

Publication api endpoint owner field GPP-Woo/GPP-publicatiebank
3 participants
@sergei-maertens @MarcoKlerks @bart-maykin