Node12+ref napi #327
Open
Node12+ref napi #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/master: (211 commits) NOJIRA: Fixed typo GPII-4231: Updating to version of universal with narrator autostart commented out GPII-3830: Mocking a wrapper fs.existsSync, rather than the real function. GPII-3830: Testing for unmounted usb drives GPII-4231: Adopted suggestion for mambo Revert "GPII-4428: Restoring icon spacing when restarting explorer." GPII-4428: Restoring icon spacing when restarting explorer. GPII-4231: Adding back one piece of mamba GPII-4231: Removing mamba GPII-4420: Handling the possibility of no installed language packs GPII-4420: Only listing languages installed by a morphic language installer GPII-4409: Improved test stability (increased timeout) GPII-4409: Refactored away null-array return of getProcessWindows GPII-4409: Launch buttons to activate existing application instance. GPII-4409: Getting the list of process windows, extracted from closeProcessByName for re-use. GPII-4382: Consistent with current universal master with fixed schemas GPII-4382: Added additional logging for SPI settings handler issues. GPII-4370: Rejecting settings handler if the settings helper fails. GPII-4382: Updated to use universal branch to test work in progress in CI. NOJIRA: Skipping service tests if running from electron. ...
* upstream/master: (110 commits) GPII-4428: Updating to current universal GPII-4470: Storing the currently active window in an environment variable. NOJIRA: Waiting for test window to show. GPII-3811: Made highcontrast theme test work GPII-3811: Fixed merge. GPII-4486 Updating universal dep GPII-4486 Forgot param portion of diff GPII-4486 Returning only the settings asked for in the payload GPII-4446: Updating to matching master Revert "GPII-3990: Using updated node-os-service." GPII-4428: Added API reference. Updating to current gpii-universal GPII-4397: Documented the userIdSource configuration. GPII-3853: Updated to matching universal release Revert "GPII-3853: Pointing back to the universal branch for metrics" GPII-3853: Pointing back to the universal branch for metrics GPII-4087: Removed windows.rm GPII-3853: Small tidy-up GPII-4446: Modifying the existing ribbon, rather than replacing it. GPII-4397: Fixed user login texts to recognised lower cased marker ...
|
CI job passed: https://ci.gpii.net/job/windows-tests/1461/ |
amb26
reviewed
Jun 16, 2020
| @@ -21,7 +21,7 @@ | |||
| "json5": "2.1.0", | |||
| "mkdirp": "0.5.1", | |||
| "minimist": "1.2.0", | |||
| "@gpii/os-service": "2.2.0", | |||
| "@gpii/os-service": "javihernandez/node-os-service#GPII-4140", | |||
There was a problem hiding this comment.
It's an update with upstream/master, which adds support for node12, see: GPII/node-os-service#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a test to see if the replacement of ref with ref-napi produces the same problems that I'm getting locally on CI