Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Morphic 1.3.5 #321

Open
wants to merge 68 commits into
base: master
Choose a base branch
from

Conversation

javihernandez
Copy link
Member

This is the working branch for Morphic 1.3.5 that is based on the 1.3.x branches.

stegru and others added 30 commits July 5, 2019 22:55
* stegru/GPII-3830:
  GPII-3830: Fixed array check in tests
  GPII-3830: Detect if a drive exists before opening it.
* stegru/GPII-3811:
  GPII-3811: Getting the localised theme names when the language changes.
  GPII-3811: Reduced the need to start a child process
  GPII-3811: Remove universal require from child process
  GPII-3845: Making displayName resolution logic more similar to previous one
  GPII-3845: Fixed options passed to child process, improved message reception and windows version branching
  GPII-3845: Added required import and fixed returned 'undefined' in case of fail
  GPII-3845: Moved high-contrast localized name retrieval operation into new subprocess
  GPII-3811: Fixed windows version check
  GPII-3811: Custom themes also working on Windows 10 older than 1809
  GPII-3811: Custom themes working on Windows 10 1809
* stegru/GPII-2338: (121 commits)
  GPII-2338: fixed require to use scoped package.
  GPII-2338: Moved os-service into the correct place (gpii-service module)
  GPII-2338: added os-service reference
  GPII-2338: fixed universal reference
  GPII-4135: Documented sendKeys syntax
  GPII-4135: Send keys implementation
  GPII-4099: Fixed incorrect argument.
  GPII-4099: Configurable user id source.
  GPII-4099: Blocked user names configurable with wildcards
  GPII-2338: Only asserting process.exit once.
  GPII-4000: Made the blocked username check case-insensitive
  GPII-3988: Added support for environmental logins in the user listeners.
  GPII-4000: Blocking some local usernames from auto-login
  GPII-3810: Fixed incorrect struct sizes
  GPII-3810: Removed repeated code in conditional in favor of ternary operator
  GPII-2338: Making the service always shutdown.
  GPII-2338: Added --shutdown option, used by the installer to make GPII shutdown.
  GPII-2338: Made the client authentication more robust.
  GPII-3810: Changed universal reference
  GPII-3728: Waiting for the initial session ("no user") to start, before auto-login
  ...
* stegru/GPII-3853:
  GPII-3853: Better fix for CI-only test failure.
  GPII-3853: Potential fix for CI-only test failure.
  GPII-3853: Updating package reference to related branch
  GPII-3853: Disabling metrics via siteConfig
  GPII-3853: Documenting recent changes
  GPII-3853: Updated test to treat space as non-printable
  GPII-3853: Recording if a morphic is active
  GPII-3853: Recording space bar
  GPII-3876: Made typing-session metric work.
  GPII-3906: app-inactive tests
  GPII-3906: Capturing window de-activation, app-inactive
  GPII-3877: Fixed negative key press times
  GPII-3878: Ignoring extreme mouse distances.
  GPII-3853: Added calculation of duration between related events.
  GPII-3853: Recording inactivity due to entering sleep mode
  GPII-3853: Implemented sub-sessions.
* origin/GPII-4033:
  GPII-4033: Re-added NotSupported check but with a non-localised string
  GPII-4033: Removed language constraints when dealing with wmi queries
* stegru/GPII-4087:
  GPII-4087: Added new hacky option for making 'gpii.windows.rm' tests pass
  GPII-4087: Added accidentally removed resolve for promise
  GPII-4087: Renamed options for deleting wallpaper files fixing redefinition
  GPII-4087: Fixed invalid reference to 'process.env'
  GPII-4087: Deleted forgotten extra space
  GPII-4087: Simplified path creation
  GPII-4087: Workaround that prevents deleting system cached wallpaper unless high-contrast is being set
  GPII-4087: Applying high-contrast if the theme is specified.
  GPII-4087: Tidied the high-contrast fix.
  GPII-4087: High-contrast fix returning the correct value.
  GPII-4087: Tidied the high-contrast fix.
  GPII-4087: Fixed the high-contrast fix.
  GPII-4087: Added hack to stop wallpaper being reset.
* stegru/GPII-4092.master:
  GPII-4092: Volume handler returns 0 on failure, instead of rejecting.
* stegru/GPII-4186:
  GPII-4186: Using windows certificate store for certificates.
* stegru/GPII-4011:
  GPII-4011: Putting line separators back to CRLF. (trying harder)
  GPII-4011: Putting line separators back to CRLF.
  GPII-4011: Showing the volume change on the screen.
* stegru/GPII-4016:
  GPII-4016: Removed amateur debugging code
  GPII-4016: Added zoom support for IE, improved Edge
  GPII-4016: App-zoom for explorer folder windows, notepad++, and wordpad.
* JavierJF/GPII-4231: (29 commits)
  GPII-4152: Changed comment style to reflect the fact that is research info
  GPII-4152: Removed included guards for header files in favour of uniform 'pragma once' usage
  GPII-4152: Added forgotten empty-line at the end of file
  GPII-4152: Added copyright headers in project files with brief description
  GPII-4152: Added example payloads that can be used to test the settingsHelper executable
  GPII-4152: Added multiprocessor compilation to other project configurations for settingsHelperTests
  GPII-4152: Changed the comment style from special test in favour of macro
  GPII-4152: Fixed the access to internal dbSettigns and the member helper function _SetValue
  GPII-4152: Removed redundant checks
  GPII-4152: Added new tests for required setting and making tests restore initial settings
  GPII-4152: Added support for serializing and comparing string value payloads
  GPII-4152: Added new checking get/set of required setting
  GPII-4231: Changed universal reference
  GPII-4152: Removed unnecessary legacy operations in 'handlePayload' function
  GPII-4152: Refactored set method using helper function encapsulating waiting logic
  GPII-4152: Reversed the VM resources to regular ones
  GPII-4152: Temporarly added more resources to VM to try to make CI pass on time
  GPII-4152: Added env variable selecting vstudio version for 'SettingsHelper' building
  GPII-4152: Uninstalled box windows-sdk-8.1 and reinstalled after windows-sdk-10 preventing sdk-8.1 corruption
  GPII-4152: Fixed non-returning payload readed from standard input
  ...
* stegru/GPII-4244:
  GPII-3572: Reading the metrics switch from site config.
  GPII-4244: Not updating files when no url is configured
  GPII-4244: Auto-updating configs implemented
  GPII-4244: Documented service.config
  GPII-4244: Expanding environment variables in the whole config object.
  GPII-4244: expandEnvironmentStrings works recursively for objects.
  GPII-2338: More config documentation.
* stegru/GPII-3853:
  GPII-3852: Applied refactoring made in universal.
* stegru/GPII-4244:
  GPII-4244: Added null reference check
* stegru/GPII-3853:
  GPII-3810: Reverting to current released version of universal
  GPII-3853: Correctly identifying UWP/modern app windows
  Removed gratuitous whitespace
  Whitelisted this package for Windows (i.e. OS == 'win32')
* stegru/GPII-3853: (22 commits)
  GPII-4208: Removed redundant inputHook
  GPII-4208: Fixed bad merge.
  GPII-4208: Removed RIDEV_NOLEGACY, which disabled input on the QS.
  GPII-2338: Updated .gitignore to ignore gpii-service build
  GPII-2338: Removed stutter
  GPII-2338: Ensuring a buffer is the correct size.
  GPII-4208: Extracted common block from if-else logic
  GPII-4208: Simplified check for checking number sign
  GPII-4208: Fixed constants location, bitmask based logic message handling and tests
  GPII-4208: Improved documentation of the returned value and used helper function 'win32error' for error construction
  GPII-4208: Changed check in favor of simpler comparison against zero
  GPII-4208: Removed unnecessary info from comments links
  GPII-4208: Removed duplicated definition of WM_INPUT
  GPII-4208: Replaced number with constant representing WM_INPUT message
  GPII-4208: Fixed metrics tests using the new way of obtaining devices input
  GPII-4208: Added comments and fixed wheel direction detection
  GPII-2338: Referencing the exact os-service version
  GPII-2338: Referencing the released scoped os-service
  GPII-2338: Added test for sending Error objects over the pipe.
  GPII-2338: Referencing universal#master.
  ...
* stegru/GPII-4403:
  GPII-4403: Using the site secret for the hmac key to generate gpiiKeys.
  GPII-4401: Generating gpiiKeys based on lowercase usernames.
* stegru/GPII-4289:
  GPII-4289: Handling the case of no taskbar
  GPII-4289: Updated tests for the new height calculation
  GPII-4289: Calculating QSS height, rather than using the window size.
@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1413/

@javihernandez
Copy link
Member Author

ok to test

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1415/

* stegru/GPII-3811:
  GPII-3811: Made highcontrast theme test work
  GPII-3811: Fixed merge.
@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1417/

@javihernandez
Copy link
Member Author

CI job failed: https://ci.gpii.net/job/windows-tests/1417/

02:26:57.061:  jq: Expected: {
    "gpii.windows.enableRegisteredAT": {
        "com.microsoft.windows.magnifier": [
            {
                "settings": {
                    "running": true
                }
            }
        ],
        "com.microsoft.windows.onscreenKeyboard": [
            {
                "settings": {
                    "running": false
                }
            }
        ]
    }
}
02:26:57.061:  jq: Actual: {
    "gpii.windows.enableRegisteredAT": {
        "com.microsoft.windows.magnifier": [
            {
                "settings": {
                    "running": undefined
                }
            }
        ],
        "com.microsoft.windows.onscreenKeyboard": [
            {
                "settings": {
                    "running": false
                }
            }
        ]
    }
}

Magnifier not started failure - ok to test

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/1418/

* stegru/GPII-4428:
  NOJIRA: Waiting for test window to show.
@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1425/

* upstream/master:
  GPII-4470: Storing the currently active window in an environment variable.
@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/1426/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/1427/

* upstream/master:
  GPII-4428: Updating to current universal
This brings stegru/universal#GPII-4500
@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1455/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/1456/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/windows-tests/1458/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1459/

@amb26
Copy link
Member

amb26 commented Jun 15, 2020

Rather severe! Unit test failure in Windows Metrics tests:

04:22:17.317:  FATAL ERROR: Uncaught exception: ok() assertion outside test context, was     at pok (\\vboxsvr\vagrant\node_modules\infusion\tests\test-core\jqUnit\js\jqUnit.js:112:15)
    at Object.fail (\\vboxsvr\vagrant\node_modules\infusion\tests\test-core\jqUnit\js\jqUnit.js:129:13)
    at Server.<anonymous> (\\vboxsvr\vagrant\gpii\node_modules\windowsMetrics\test\WindowsMetricsTests.js:983:16)

@amb26
Copy link
Member

amb26 commented Jun 15, 2020

ok to test

@javihernandez
Copy link
Member Author

javihernandez commented Jun 15, 2020

CI job failed: https://ci.gpii.net/job/windows-tests/1459/

unit tests failed due to an error in the metrics log server

04:22:17.317:  FATAL ERROR: Uncaught exception: ok() assertion outside test context, was     at pok (\\vboxsvr\vagrant\node_modules\infusion\tests\test-core\jqUnit\js\jqUnit.js:112:15)
    at Object.fail (\\vboxsvr\vagrant\node_modules\infusion\tests\test-core\jqUnit\js\jqUnit.js:129:13)
    at Server.<anonymous> (\\vboxsvr\vagrant\gpii\node_modules\windowsMetrics\test\WindowsMetricsTests.js:983:16)
    at Server.emit (events.js:182:13)
    at emitErrorNT (net.js:1313:8)
    at process._tickCallback (internal/process/next_tick.js:63:19)
    at Function.Module.runMain (internal/modules/cjs/loader.js:745:11)
    at runMain (C:\Users\vagrant\.node-spawn-wrap-5968-b21ca4e6a3af\node:68:10)
    at Function.<anonymous> (C:\Users\vagrant\.node-spawn-wrap-5968-b21ca4e6a3af\node:171:5)
    at Object.<anonymous> (\\vboxsvr\vagrant\node_modules\nyc\bin\wrap.js:27:4)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/mod .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]

acceptance tests failing due to volume's actual value not matching the expected one

     {
         "settings": {
             "Volume": {
-                "value": 0.673242
+                "value": 0.68
             }
         }
     }

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/windows-tests/1460/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants