Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-4500: Fixed the "preference" metric. #878

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stegru
Copy link
Member

@stegru stegru commented Jun 8, 2020

Metric is captured when a preference has been applied.

From the snapset_2B preference set:

{
    module: "metrics",
    event: "preference",
    data: {
        name: "http://registry.gpii.net/common/cursorSize",
        setTo: "1"
    }
}
{
    module: "metrics",
    event: "preference",
    data: {
        name: "http://registry.gpii.net/common/DPIScale",
        setTo: "2"
    }
}
{
    module: "metrics",
    event: "preference",
    data: {
        name: "http://registry.gpii.net/common/highContrastTheme",
        setTo: "white-black"
    }
}

@gpii-bot
Copy link

gpii-bot commented Jun 8, 2020

CI job failed: https://ci.gpii.net/job/universal-tests/2353/

@gpii-bot
Copy link

gpii-bot commented Jun 9, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2355/

@@ -110,7 +110,7 @@ fluid.defaults("gpii.metrics.lifecycle", {
}
},
listeners: {
"{lifecycleManager}.events.onCreate": {
"onCreate": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onCreate.trackPrefsSetChange?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants