-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GPII-4125: Initial implementation of the "live" solutions registry. #860
base: master
Are you sure you want to change the base?
Conversation
…orms and new tests.
…l solutions and to assemble context files from solutions. Pointed all tests at the new data.
CI job failed: https://ci.gpii.net/job/universal-tests/2242/ |
Test hang that I can reproduce locally, working on it now. |
CI job failed: https://ci.gpii.net/job/universal-tests/2243/ |
The failures at the moment are with MAGic and JAWS, which I converted to use the type/parents inheritance mechanisms. I am adding explicit tests for those mechanisms and am hardening those up now. |
… replacements for legacy context files.
CI job passed: https://ci.gpii.net/job/universal-tests/2252/ |
@amb26, this now includes the initial breakup and "rehydration" of the legacy "context files" like win32.json5. Although there is certainly still work to be done, the type/parents inheritance and other core material are there if you have a minute to look it over. |
CI job failed: https://ci.gpii.net/job/universal-tests/2257/ |
The last test failure was a result of not having generated an LSR entry for the new colour filters solution brought in when I merged with upstream master. Should be fixed now. |
CI job passed: https://ci.gpii.net/job/universal-tests/2258/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2265/ |
…efully) resolve downstream acceptance test failures.
CI job passed: https://ci.gpii.net/job/universal-tests/2268/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2270/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2354/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2358/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2359/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2360/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2367/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2371/ |
CI job failed: https://ci.gpii.net/job/universal-tests/2389/ |
CI job failed: https://ci.gpii.net/job/universal-tests/2390/ |
CI job failed: https://ci.gpii.net/job/universal-tests/2391/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2392/ |
CI job passed: https://ci.gpii.net/job/universal-tests/2393/ |
CI job failed: https://ci.gpii.net/job/universal-tests/2394/ |
The tests are failing because the change from JSON5->JSON revealed that the files were not properly indented. I'll fix that shortly. |
CI job passed: https://ci.gpii.net/job/universal-tests/2395/ |
CI job failed: https://ci.gpii.net/job/universal-tests/2396/ |
See GPII-4125 for details.
@amb26, this pull is not ready for review, I am submitting it to confirm that the generated "context files" work as a drop-in replacement for the legacy files in CI.