Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-4125: Initial implementation of the "live" solutions registry. #860

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

the-t-in-rtf
Copy link
Member

See GPII-4125 for details.

@amb26, this pull is not ready for review, I am submitting it to confirm that the generated "context files" work as a drop-in replacement for the legacy files in CI.

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/universal-tests/2242/

@the-t-in-rtf
Copy link
Member Author

Test hang that I can reproduce locally, working on it now.

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/universal-tests/2243/

@the-t-in-rtf
Copy link
Member Author

the-t-in-rtf commented Mar 24, 2020

The failures at the moment are with MAGic and JAWS, which I converted to use the type/parents inheritance mechanisms. I am adding explicit tests for those mechanisms and am hardening those up now.

@gpii-bot
Copy link

gpii-bot commented Apr 2, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2252/

@the-t-in-rtf
Copy link
Member Author

@amb26, this now includes the initial breakup and "rehydration" of the legacy "context files" like win32.json5. Although there is certainly still work to be done, the type/parents inheritance and other core material are there if you have a minute to look it over.

@gpii-bot
Copy link

gpii-bot commented Apr 6, 2020

CI job failed: https://ci.gpii.net/job/universal-tests/2257/

@the-t-in-rtf
Copy link
Member Author

The last test failure was a result of not having generated an LSR entry for the new colour filters solution brought in when I merged with upstream master. Should be fixed now.

@gpii-bot
Copy link

gpii-bot commented Apr 9, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2258/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2265/

…efully) resolve downstream acceptance test failures.
@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2268/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2270/

@gpii-bot
Copy link

gpii-bot commented Jun 9, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2354/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2358/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2359/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2360/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2367/

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/2371/

@gpii-bot
Copy link

gpii-bot commented Jul 2, 2020

CI job failed: https://ci.gpii.net/job/universal-tests/2389/

@gpii-bot
Copy link

gpii-bot commented Jul 2, 2020

CI job failed: https://ci.gpii.net/job/universal-tests/2390/

@gpii-bot
Copy link

gpii-bot commented Jul 2, 2020

CI job failed: https://ci.gpii.net/job/universal-tests/2391/

@gpii-bot
Copy link

gpii-bot commented Jul 2, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2392/

@gpii-bot
Copy link

gpii-bot commented Jul 6, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2393/

@gpii-bot
Copy link

gpii-bot commented Jul 6, 2020

CI job failed: https://ci.gpii.net/job/universal-tests/2394/

@the-t-in-rtf
Copy link
Member Author

the-t-in-rtf commented Jul 6, 2020

The tests are failing because the change from JSON5->JSON revealed that the files were not properly indented. I'll fix that shortly.

@gpii-bot
Copy link

gpii-bot commented Jul 6, 2020

CI job passed: https://ci.gpii.net/job/universal-tests/2395/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/universal-tests/2396/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants