Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-2653: Initial onboarding of the PSP - starting with just the language setting #606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amb26
Copy link
Member

@amb26 amb26 commented Apr 23, 2018

No description provided.

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/825/

@gtirloni
Copy link
Contributor

gtirloni commented Jun 1, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jun 1, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/880/

@gtirloni
Copy link
Contributor

gtirloni commented Jun 1, 2018

@amb26 I think you just need to merge scripts/vagrantCloudBasedContainers.sh because the repository name for the preferences loader might have changed. Otherwise the build looks okay.

@gpii-bot
Copy link

gpii-bot commented Jun 1, 2018

CI job failed: https://ci.gpii.net/job/universal-tests/885/

@amb26
Copy link
Member Author

amb26 commented Jun 1, 2018

Failed due to https://issues.gpii.net/browse/GPII-3094, trying again

@amb26
Copy link
Member Author

amb26 commented Jun 1, 2018

ok to test

@gpii-bot
Copy link

gpii-bot commented Jun 1, 2018

CI job passed: https://ci.gpii.net/job/universal-tests/887/

Copy link
Member

@javihernandez javihernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the two comments I just provided, this is looking great.
In addition to this, we need to add:

  • Tests
  • A description of the solution
  • An np set that one can use to test this functionality

@@ -25,6 +25,9 @@
"http://registry.gpii.net/common/highContrast/enabled": true,
"http://registry.gpii.net/common/highContrastTheme": "white-black",
"http://registry.gpii.net/common/supportTool": ["dictionary"]
},
"http://registry.gpii.net/applications/net.gpii.psp": {
"http://registry.gpii.net/common/language": "en"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that, according to #640, this should be "en-US", right @danailbd ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I think it should

"path": "net.gpii.psp"
},
"supportedSettings": {
"language": {},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to include the metadata for this settitng? I guess that we want it to be there if we want to get it rendered in the PSP.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in order to support editing it in the PPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants