Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPII-4218: Send UIO+ settings to Morphic #52

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

jobara
Copy link
Collaborator

@jobara jobara commented Jun 10, 2020

https://issues.gpii.net/browse/GPII-4218

Requires changes to Universal for accepting the settings from UIO+ for Morphic.

@jobara
Copy link
Collaborator Author

jobara commented Jun 10, 2020

@klown this is a draft PR containing the UIO+ related changes for GPII-4218

@amb26
Copy link
Member

amb26 commented Jun 10, 2020

Cheers - I assume this will be updated in the light of fluid-project/uio-plus#17

@jobara
Copy link
Collaborator Author

jobara commented Jun 10, 2020

@amb26 thanks for merging that. I'll make a new dev release of UIO+ and update this PR with that. However, it won't really affect the code, as I've re-implemented the updateSettings invoker here because it needs to have a fallback to the default settings in the case that no settings are returned from Morphic.

jobara added 2 commits June 10, 2020 10:29
Currently we do not provide any special handling for these messags other 
than relaying into an event. However, this is a rough in implementation 
in case we require to wait for or in some other way respond to these 
confirmations.
@jobara jobara marked this pull request as ready for review June 24, 2020 17:13
@jobara
Copy link
Collaborator Author

jobara commented Jun 24, 2020

@amb26 given the state of Morphic Classic, should we tag and create GitHub release before merging this PR?

@amb26
Copy link
Member

amb26 commented Jun 24, 2020

Yes, please issue a release and indicate in its release notes that it is the last release compatible with the last official release of Morphic Classic, 1.3.5

@jobara
Copy link
Collaborator Author

jobara commented Jun 24, 2020

@amb26 I've tagged and created a GitHub Release. I didn't bother publishing to the Chrome Web Store because that will get overwritten with what we publish after this PR is merged.

@jobara
Copy link
Collaborator Author

jobara commented Jun 24, 2020

@amb26 I bumped the version number to "0.2.0" as I figure this will be the last release and will drop the beta from tags and etc. If you think I should keep with the beta versioning I can switch it up.

see: Manifest - Version

@jobara jobara requested a review from amb26 June 30, 2020 18:47
@jobara
Copy link
Collaborator Author

jobara commented Jun 30, 2020

@amb26 when you review this PR, could you also update the description of the repository? I don't seem to have access to do that. Could you please change "UI Options Plus Chrome Extension" to be "UIO+ For Morphic"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants