Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master 3.0, add privileges to role management #1460

Merged
merged 5 commits into from
Sep 20, 2023

Conversation

sylvain121
Copy link

This PR:
Remove old permission's system management and code references.
Add privileges management to role

@grossmj
Copy link
Member

grossmj commented Sep 19, 2023

Thanks for the PR :)

I spotted one issue so far.

Screenshot from 2023-09-19 17-55-37

Clicking on a group produces an 404 error because /access/groups/{user_group_id}/roles doesn't exist, groups are associated with a role when a new ACE is created.

@grossmj
Copy link
Member

grossmj commented Sep 19, 2023

Remove old permission's system management and code references.
Add privileges management to role

Just noticed that groups haven't been modified yet. Should I just merge this PR and the rest will come in other PRs?

@grossmj
Copy link
Member

grossmj commented Sep 19, 2023

This is the SQL model for the RBAC system, I thought this may help you to see how things are related to each other.

Screenshot from 2023-09-19 18-06-18

@sylvain121
Copy link
Author

Hi,
Yes, updated Groups management and ACLs will be submitted in next PRs.
You can merge it, or wait for others PRs coming this week.

@grossmj grossmj merged commit b106f31 into GNS3:master-3.0 Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants