Skip to content

miles: drive the upstream-based tinker-seam interface #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GavinZhu-GMI merged 7 commits into from
Jul 14, 2026
Merged

miles: drive the upstream-based tinker-seam interface #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2e93759
miles: align optim to fork Ray interface + overlay fork miles in profile
GavinZhu-GMI Jul 13, 2026
0901a23
miles: LoRA alpha defaults to rank, not 0 (zero-gradient bug)
GavinZhu-GMI Jul 13, 2026
df0eca7
miles profile: overlay via git checkout, not cp
GavinZhu-GMI Jul 13, 2026
2898626
miles: adapt backend to the tinker-seam interface (upstream-based miles)
GavinZhu-GMI Jul 13, 2026
86ca033
miles seam: first-boot fixes from gate validation on ns.config
GavinZhu-GMI Jul 13, 2026
8438606
miles seam: G3 fixes — full RL-mode stack + cookbook SFT run green
GavinZhu-GMI Jul 13, 2026
562bad4
miles: self-contained comments (drop monorepo spec references)
GavinZhu-GMI Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/deploy_tinkercloud.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ fi

# --- 4. in-container setup ---------------------------------------------------
echo "==> [4/6] running in-container setup (profile=$PROFILE)"
EX "PROFILE=$PROFILE bash /tmp/setup_container.sh"
EX "PROFILE=$PROFILE MILES_REPO='${MILES_REPO:-}' MILES_REF='${MILES_REF:-}' bash /tmp/setup_container.sh"

if [ "$RUN_SERVER" = 0 ]; then
# bionemo profile: env only — no Ray, no server (no working evo2 server yet).
Expand Down
22 changes: 21 additions & 1 deletion scripts/lib/setup_container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,27 @@ if [ "$PROFILE" = nemo_rl ]; then
PKG=$(python3 -c 'import nemo_rl, os; print(os.path.dirname(nemo_rl.__file__))')
cp -r /tmp/RL/nemo_rl/. "$PKG/"
elif [ "$PROFILE" = miles ]; then
python3 -c 'import miles; print("miles pre-installed OK")'
# Overlay the GMI miles fork onto the image's editable install: the base image's
# baked miles predates the Tinker Ray-orchestration interface (forward_backward_only,
# apply_optimizer_step(learning_rate=), apply_optimizer_step_and_sync). Fork main is
# the maintained branch (PR merges fix_hackathon_rebased -> main).
MILES_REPO="${MILES_REPO:-https://github.com/GavinZhu-GMI/miles.git}"
MILES_REF="${MILES_REF:-main}"
MPKG=$(python3 -c 'import miles, os; print(os.path.dirname(miles.__file__))')
MROOT=$(dirname "$MPKG")
if git -C "$MROOT" rev-parse --git-dir >/dev/null 2>&1; then
# miles is an editable checkout (miles image): update it via git so the
# worktree IS the pinned ref — a bare cp leaves stale files and a dirty
# git status that masquerades as unsaved work.
git -C "$MROOT" fetch -q --depth 1 "$MILES_REPO" "$MILES_REF"
git -C "$MROOT" checkout -qf FETCH_HEAD
git -C "$MROOT" clean -qfd -- miles/
else
rm -rf /tmp/miles_src "$MPKG"
git clone -q --depth 1 --branch "$MILES_REF" "$MILES_REPO" /tmp/miles_src
cp -r /tmp/miles_src/miles "$MPKG"
fi
python3 -c 'import miles; print("miles fork overlaid OK ('"$MILES_REF"')")'
fi

# SDK + cookbook editable installs
Expand Down
Loading