Skip to content

feat(transaction): add chain_id to Transaction#1

Merged
shamardy merged 5 commits intoGLEECBTC:masterfrom
dimxy:add-chain-id
Apr 4, 2024
Merged

feat(transaction): add chain_id to Transaction#1
shamardy merged 5 commits intoGLEECBTC:masterfrom
dimxy:add-chain-id

Conversation

@dimxy
Copy link
Copy Markdown
Collaborator

@dimxy dimxy commented Mar 24, 2024

No description provided.

laruh
laruh previously approved these changes Mar 28, 2024
Copy link
Copy Markdown

@laruh laruh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dimxy
Copy link
Copy Markdown
Collaborator Author

dimxy commented Mar 30, 2024

I had to add rust-toolchain.toml because tests did not build due to some dependency lib asking for rust 1.73.0. And after that I fixed couple tests by adding new chain_id field.

Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shamardy shamardy merged commit 01de1d7 into GLEECBTC:master Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants