Skip to content

Update makerbot price_url param from string to list#302

Merged
gcharang merged 5 commits intodevfrom
makerbot-price-url
Sep 13, 2024
Merged

Update makerbot price_url param from string to list#302
gcharang merged 5 commits intodevfrom
makerbot-price-url

Conversation

@smk762
Copy link
Copy Markdown
Contributor

@smk762 smk762 commented Jul 25, 2024

Ref: GLEECBTC/komodo-defi-framework#2027

To test:

  • Using latest dev branch mm2 (kdf) binary, activate KMD and LTC.
  • Use the example in doc to start the makerbot. If KMD/LTC wallets are funded, set a reasonable percentage in case a trade intiates.
  • Check the logs. At each bot price refresh loop, it should indicate where pricing info was sourced from.

Copy link
Copy Markdown

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@github-actions
Copy link
Copy Markdown

Preview for merge commit: 162807a, available on cloudflare at: https://de52f0c6.komodo-docs.pages.dev/en/docs/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2024

Preview for merge commit: cb89ce0, available on cloudflare at: https://450ad134.komodo-docs.pages.dev/en/docs/

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 9, 2024

Preview for merge commit: 199502e, available on cloudflare at: https://d15eeeff.komodo-docs.pages.dev/en/docs/

@gcharang gcharang merged commit d4c504d into dev Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants