Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe code refactors methods in the GitHub file downloader to standardize file download URL construction using a new helper. Method signatures are updated to pass repository commit information, ensuring download URLs are correctly generated for each file and commit. The changes affect both asynchronous and synchronous folder content downloads. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the CDN URL usage in GitHubFileDownloader and updates the corresponding function signatures and URL-building logic.
- Renames _fetchFileContent’s argument from fileUrl to relativeFilePath
- Introduces a new helper method _buildFileDownloadUrl for consistent URL construction
- Updates calls to _downloadFolderContents and _downloadFolderContentsSync to pass repoCommit
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Visit the preview URL for this PR (updated for commit 4f216f0): https://komodo-defi-sdk--pr65-codex-update-downloa-7xj1on5t.web.app (expires Wed, 04 Jun 2025 12:23:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347 |
Summary
_fetchFileContentargumentTesting
flutter pub get --enforce-lockfile --offlinedart format packages/komodo_wallet_build_transformer/lib/src/steps/github/github_file_downloader.dartdart fix --applyflutter analyze(fails: many existing issues)flutter build web(fails to fetch packages offline)Summary by CodeRabbit