Skip to content

Fix CDN usage in GitHubFileDownloader#65

Merged
CharlVS merged 2 commits intodevfrom
codex/update-download-logic-to-use-repocontenturl
May 28, 2025
Merged

Fix CDN usage in GitHubFileDownloader#65
CharlVS merged 2 commits intodevfrom
codex/update-download-logic-to-use-repocontenturl

Conversation

@takenagain
Copy link
Copy Markdown
Contributor

@takenagain takenagain commented May 28, 2025

Summary

  • fix CDN url usage when downloading folders in GitHubFileDownloader
  • rename _fetchFileContent argument

Testing

  • flutter pub get --enforce-lockfile --offline
  • dart format packages/komodo_wallet_build_transformer/lib/src/steps/github/github_file_downloader.dart
  • dart fix --apply
  • flutter analyze (fails: many existing issues)
  • flutter build web (fails to fetch packages offline)

Summary by CodeRabbit

  • Refactor
    • Improved the reliability of file downloads from GitHub repositories by standardizing how download URLs are constructed, ensuring files are fetched accurately based on the repository commit.

Copilot AI review requested due to automatic review settings May 28, 2025 10:37
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 28, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The code refactors methods in the GitHub file downloader to standardize file download URL construction using a new helper. Method signatures are updated to pass repository commit information, ensuring download URLs are correctly generated for each file and commit. The changes affect both asynchronous and synchronous folder content downloads.

Changes

File(s) Change Summary
packages/komodo_wallet_build_transformer/lib/src/steps/github/github_file_downloader.dart Refactored URL construction logic; updated method signatures to accept repo commit; added helper method for building download URLs; ensured all folder downloads use updated URLs.

Poem

A rabbit hops through code so neat,
Download URLs now complete!
With helper paws, commits in tow,
Each file’s path will surely show.
Refactored flows, a tidy den—
GitHub files fetched once again!
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@takenagain takenagain marked this pull request as draft May 28, 2025 10:38
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the CDN URL usage in GitHubFileDownloader and updates the corresponding function signatures and URL-building logic.

  • Renames _fetchFileContent’s argument from fileUrl to relativeFilePath
  • Introduces a new helper method _buildFileDownloadUrl for consistent URL construction
  • Updates calls to _downloadFolderContents and _downloadFolderContentsSync to pass repoCommit

@takenagain takenagain self-assigned this May 28, 2025
@takenagain takenagain added the bug Something isn't working label May 28, 2025
@takenagain
Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 28, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@takenagain takenagain marked this pull request as ready for review May 28, 2025 12:21
@takenagain takenagain requested a review from CharlVS May 28, 2025 12:21
@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 4f216f0):

https://komodo-defi-sdk--pr65-codex-update-downloa-7xj1on5t.web.app

(expires Wed, 04 Jun 2025 12:23:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347

@CharlVS CharlVS merged commit 9aa16b8 into dev May 28, 2025
5 of 7 checks passed
@CharlVS CharlVS deleted the codex/update-download-logic-to-use-repocontenturl branch May 28, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants