Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Visit the preview URL for this PR (updated for commit 9bd8215): https://komodo-defi-sdk--pr62-codex-verify-ibc-coi-7vjdqr3f.web.app (expires Thu, 29 May 2025 14:02:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for specifying an IBC source channel when creating withdrawal requests. Key changes include adding a new field (ibcSourceChannel) of type int to the withdrawal types, updating the withdrawal screen to capture and pass the IBC channel from user input, and propagating the new parameter through the RPC methods and request objects.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/komodo_defi_types/lib/src/withdrawal/withdrawal_types.dart | New ibcSourceChannel field added to WithdrawParameters along with its JSON serialization and inclusion in the equality list. |
| packages/komodo_defi_sdk/example/lib/screens/withdrawal_page.dart | Withdrawal screen updated to parse and pass the IBC channel from user input, including setting the keyboard type to number. |
| packages/komodo_defi_rpc_methods/lib/src/rpc_methods/withdrawal/withdrawal_rpc_namespace.dart | The new ibcSourceChannel parameter is forwarded as part of the withdrawal methods. |
| packages/komodo_defi_rpc_methods/lib/src/rpc_methods/withdrawal/withdraw_request.dart | Changed the type of ibcSourceChannel from String? to int? and removed legacy migration comments. |
Comments suppressed due to low confidence (2)
packages/komodo_defi_types/lib/src/withdrawal/withdrawal_types.dart:156
- Please add unit tests to verify that the new ibcSourceChannel field is correctly set and serialized.
this.ibcSourceChannel,
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/withdrawal/withdraw_request.dart:52
- Review and remove legacy migration comments if they are no longer applicable, and update the documentation to clearly reflect that ibcSourceChannel is now an int.
//TODO! Migrate breaking changes when the ibc_source_channel is
Summary
ibc_source_channelwhen creating withdraw requestsibcSourceChannelonWithdrawParametersTesting
dart format -o none --set-exit-if-changed .flutter analyze --no-pub(fails: 1359 issues found)