Skip to content

feat: add ibc source channel support#62

Merged
CharlVS merged 1 commit intodevfrom
codex/verify-ibc-coins-implementation-in-kdf-api
May 23, 2025
Merged

feat: add ibc source channel support#62
CharlVS merged 1 commit intodevfrom
codex/verify-ibc-coins-implementation-in-kdf-api

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented May 22, 2025

Summary

  • support ibc_source_channel when creating withdraw requests
  • expose ibcSourceChannel on WithdrawParameters
  • pass the channel from the withdrawal screen example

Testing

  • dart format -o none --set-exit-if-changed .
  • flutter analyze --no-pub (fails: 1359 issues found)

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@CharlVS CharlVS changed the title Add ibc source channel support feat: add ibc source channel support May 22, 2025
@CharlVS CharlVS self-assigned this May 22, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 9bd8215):

https://komodo-defi-sdk--pr62-codex-verify-ibc-coi-7vjdqr3f.web.app

(expires Thu, 29 May 2025 14:02:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347

@CharlVS CharlVS marked this pull request as ready for review May 23, 2025 08:20
Copilot AI review requested due to automatic review settings May 23, 2025 08:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for specifying an IBC source channel when creating withdrawal requests. Key changes include adding a new field (ibcSourceChannel) of type int to the withdrawal types, updating the withdrawal screen to capture and pass the IBC channel from user input, and propagating the new parameter through the RPC methods and request objects.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/komodo_defi_types/lib/src/withdrawal/withdrawal_types.dart New ibcSourceChannel field added to WithdrawParameters along with its JSON serialization and inclusion in the equality list.
packages/komodo_defi_sdk/example/lib/screens/withdrawal_page.dart Withdrawal screen updated to parse and pass the IBC channel from user input, including setting the keyboard type to number.
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/withdrawal/withdrawal_rpc_namespace.dart The new ibcSourceChannel parameter is forwarded as part of the withdrawal methods.
packages/komodo_defi_rpc_methods/lib/src/rpc_methods/withdrawal/withdraw_request.dart Changed the type of ibcSourceChannel from String? to int? and removed legacy migration comments.
Comments suppressed due to low confidence (2)

packages/komodo_defi_types/lib/src/withdrawal/withdrawal_types.dart:156

  • Please add unit tests to verify that the new ibcSourceChannel field is correctly set and serialized.
this.ibcSourceChannel,

packages/komodo_defi_rpc_methods/lib/src/rpc_methods/withdrawal/withdraw_request.dart:52

  • Review and remove legacy migration comments if they are no longer applicable, and update the documentation to clearly reflect that ibcSourceChannel is now an int.
//TODO! Migrate breaking changes when the ibc_source_channel is

@CharlVS CharlVS merged commit aa937aa into dev May 23, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants