feat(auth): allow weak password in auth options by takenagain · Pull Request #54 · GLEECBTC/komodo-defi-sdk-flutter

takenagain · 2025-05-11T20:26:40Z

Adds a boolean flag to the AuthOptions class to allow users of the SDK to control the allow_weak_passwords KDF field if desired (support, debugging, etc).

Summary by CodeRabbit

New Features
- Added support for allowing weak passwords during authentication and registration, configurable via a new option in authentication settings.
Bug Fixes
- Ensured that the new weak password option is properly handled during wallet startup configuration.
Documentation
- Updated JSON serialization and equality checks to include the new weak password setting in authentication options.

coderabbitai · 2025-05-11T20:26:46Z

Walkthrough

Support for an allowWeakPassword option was added across authentication-related code. The AuthOptions class now includes this field, and it is integrated into both the startup configuration generation and the authentication service logic, allowing explicit control over permitting weak passwords during sign-in and registration.

Changes

File(s)	Change Summary
`packages/komodo_defi_types/lib/src/auth/auth_options.dart`	Added `allowWeakPassword` boolean field (default `false`) to `AuthOptions`, updated constructor, JSON, equality.
`packages/komodo_defi_local_auth/lib/src/auth/auth_service_kdf_extension.dart`	Added `allowWeakPassword` optional parameter to `_generateStartupConfig` method signature and logic.
`packages/komodo_defi_local_auth/lib/src/auth/auth_service.dart`	Passed `allowWeakPassword` from `AuthOptions` into `_generateStartupConfig` in `signIn` and `register` methods.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AuthService
    participant KdfExtensions
    participant StartupConfig

    User->>AuthService: signIn/register (AuthOptions)
    AuthService->>KdfExtensions: _generateStartupConfig(..., allowWeakPassword)
    KdfExtensions->>StartupConfig: generateWithDefaults(..., allowWeakPassword)
    StartupConfig-->>KdfExtensions: Config object
    KdfExtensions-->>AuthService: Config object
    AuthService-->>User: Auth result

Suggested reviewers

CharlVS

Poem

A hop and a skip, a password anew,
Now weak ones may pass, if you want them to!
Options expanded, the code’s feeling bright,
Auth flows more gently, both day and night.
🐇✨

With every new flag, we leap to the sky—
Secure or relaxed, you choose how to try!

Tip

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 48d8e48 and 35598ce.

📒 Files selected for processing (3)

packages/komodo_defi_local_auth/lib/src/auth/auth_service.dart (2 hunks)
packages/komodo_defi_local_auth/lib/src/auth/auth_service_kdf_extension.dart (2 hunks)
packages/komodo_defi_types/lib/src/auth/auth_options.dart (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: build_and_preview_sdk_example_preview
GitHub Check: build_and_preview_playground_preview

🔇 Additional comments (3)

packages/komodo_defi_types/lib/src/auth/auth_options.dart (1)

8-8: Implementation of allowWeakPassword looks good and consistent.

The new boolean field has been properly integrated into all necessary components of the AuthOptions class - constructor (with a secure default of false), JSON serialization/deserialization, field declaration, and equality comparison via the props list. The snake_case naming convention is maintained for JSON keys.

Also applies to: 15-15, 20-20, 25-25, 30-30

packages/komodo_defi_local_auth/lib/src/auth/auth_service.dart (1)

146-146: Correct propagation of the allowWeakPassword option.

The implementation properly passes the allowWeakPassword field from the AuthOptions to the _generateStartupConfig method in both the signIn and register methods, ensuring the option is consistently used throughout the authentication flow.

Also applies to: 192-192

packages/komodo_defi_local_auth/lib/src/auth/auth_service_kdf_extension.dart (1)

172-172: Correct implementation in the KDF extension.

The _generateStartupConfig method has been properly updated to accept the new allowWeakPassword parameter and pass it to the KdfStartupConfig.generateWithDefaults method. The default value of false maintains consistent behavior with the AuthOptions class and ensures security by default.

Also applies to: 188-188

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

takenagain · 2025-05-11T20:29:53Z

@coderabbitai review

coderabbitai · 2025-05-11T20:29:58Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2025-05-11T20:32:42Z

Visit the preview URL for this PR (updated for commit 35598ce):

https://komodo-defi-sdk--pr54-feat-allow-weak-pass-4ruuov2b.web.app

_{(expires Sun, 18 May 2025 20:32:36 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 7f9f5ac39928f333b6e8fcefb7138575e24ed347}

Copilot

Pull Request Overview

This PR introduces a new boolean flag in the AuthOptions class to allow weak passwords, making it configurable for authentication and registration flows. The changes include:

Adding the allowWeakPassword flag with a default value to the AuthOptions class.
Updating JSON serialization, deserialization, and equality checks to reflect the new flag.
Propagating the new flag through various authentication service extensions.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/komodo_defi_types/lib/src/auth/auth_options.dart	Introduces and handles the new allowWeakPassword flag in the AuthOptions class.
packages/komodo_defi_local_auth/lib/src/auth/auth_service_kdf_extension.dart	Propagates allowWeakPassword as a parameter in KDF-related service configuration.
packages/komodo_defi_local_auth/lib/src/auth/auth_service.dart	Passes the allowWeakPassword flag to authentication configuration calls.

Comments suppressed due to low confidence (1)

packages/komodo_defi_local_auth/lib/src/auth/auth_service.dart:146

Ensure that there are unit tests covering both the true and false scenarios for 'allowWeakPassword' to validate the new behavior.

allowWeakPassword: options.allowWeakPassword,

Copilot · 2025-05-11T20:41:35Z

 class AuthOptions extends Equatable {
  const AuthOptions({
    required this.derivationMethod,
+    this.allowWeakPassword = false,


[nitpick] Consider adding a comment explaining the purpose and usage scenarios of 'allowWeakPassword' for greater clarity and maintainability.

feat(auth): allow weak password in auth options

35598ce

takenagain self-assigned this May 11, 2025

takenagain mentioned this pull request May 11, 2025

fix(auth): wallet password validation in creation and update flows GLEECBTC/gleec-wallet#2620

Merged

10 tasks

takenagain marked this pull request as ready for review May 11, 2025 20:41

takenagain requested review from CharlVS and Copilot May 11, 2025 20:41

Copilot AI reviewed May 11, 2025

View reviewed changes

CharlVS approved these changes May 12, 2025

View reviewed changes

CharlVS merged commit 9519157 into dev May 12, 2025
6 of 7 checks passed

coderabbitai bot mentioned this pull request Oct 26, 2025

fix(rpc): minimise RPC usage with comprehensive caching and streaming support #262

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(auth): allow weak password in auth options#54

feat(auth): allow weak password in auth options#54
CharlVS merged 1 commit intodevfrom
feat/allow-weak-password

takenagain commented May 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented May 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

takenagain commented May 11, 2025

Uh oh!

coderabbitai bot commented May 11, 2025

Uh oh!

github-actions bot commented May 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

takenagain commented May 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented May 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

takenagain commented May 11, 2025

Uh oh!

coderabbitai bot commented May 11, 2025

Uh oh!

github-actions bot commented May 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

takenagain commented May 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)