fix(market-data): add CoinGecko failure cooldown and harden icon precache#346
Merged
fix(market-data): add CoinGecko failure cooldown and harden icon precache#346
Conversation
When getCoinList() failed, _cachedCoinList stayed null and every subsequent price request re-triggered the API call via supports(), creating a request storm that exhausted rate limits. Add a 5-minute cooldown after failures to prevent retry spam, matching the existing RepositoryFallbackMixin backoff duration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Visit the preview URL for this PR (updated for commit 87a9475): https://komodo-playground--pr346-fix-icon-precache-jsqirumn.web.app (expires Mon, 06 Apr 2026 20:46:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
2 tasks
CharlVS
added a commit
that referenced
this pull request
Apr 1, 2026
…ache (#346) * fix(ui): avoid duplicate icon precache requests * fix(ui): retry CDN icon loads after transient failures * fix(ui): harden icon precache fallback and manifest caching * fix(market-data): add failure cooldown to CoinGecko coin list fetching When getCoinList() failed, _cachedCoinList stayed null and every subsequent price request re-triggered the API call via supports(), creating a request storm that exhausted rate limits. Add a 5-minute cooldown after failures to prevent retry spam, matching the existing RepositoryFallbackMixin backoff duration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getCoinList()failed, every subsequent price request re-triggered the API call viasupports(), creating a request storm that exhausted rate limits. Added a 5-minute failure cooldown to prevent retry spam.Test plan
supports()returns false without API call, success caching)🤖 Generated with Claude Code