Skip to content

feat(sdk): add token safety and fee support helpers#319

Merged
CharlVS merged 1 commit intodevfrom
feat/sdk-pending-updates
Mar 18, 2026
Merged

feat(sdk): add token safety and fee support helpers#319
CharlVS merged 1 commit intodevfrom
feat/sdk-pending-updates

Conversation

@CharlVS
Copy link
Copy Markdown
Collaborator

@CharlVS CharlVS commented Mar 18, 2026

Summary

  • prevent custom-token storage collisions unless the stored and requested contracts are the same on the same network
  • export shared custom-token exception types and add storage tests for TRC20 conflict handling
  • add explicit fee-estimation support classification for withdrawal protocols and cover unsupported TRX/TRC20 behavior in tests
  • update the bundled coins commit in the framework build config

Verification

  • dart format sdk/packages/komodo_coin_updates/lib/src/coins_config/custom_token_storage.dart sdk/packages/komodo_coin_updates/lib/src/coins_config/custom_token_store.dart sdk/packages/komodo_coin_updates/test/custom_token_storage_test.dart sdk/packages/komodo_defi_sdk/lib/src/withdrawals/withdrawal_manager.dart sdk/packages/komodo_defi_sdk/test/withdrawals/withdrawal_manager_fee_support_test.dart sdk/packages/komodo_defi_types/lib/komodo_defi_types.dart sdk/packages/komodo_defi_types/lib/src/types.dart sdk/packages/komodo_defi_types/lib/src/assets/custom_token_exceptions.dart
  • flutter analyze sdk/packages/komodo_coin_updates/lib/src/coins_config/custom_token_storage.dart sdk/packages/komodo_coin_updates/lib/src/coins_config/custom_token_store.dart sdk/packages/komodo_coin_updates/test/custom_token_storage_test.dart sdk/packages/komodo_defi_sdk/lib/src/withdrawals/withdrawal_manager.dart sdk/packages/komodo_defi_sdk/test/withdrawals/withdrawal_manager_fee_support_test.dart sdk/packages/komodo_defi_types/lib/komodo_defi_types.dart sdk/packages/komodo_defi_types/lib/src/types.dart sdk/packages/komodo_defi_types/lib/src/assets/custom_token_exceptions.dart

Notes

  • the targeted analyze pass reported only info-level lint findings in pre-existing legacy areas of withdrawal_manager.dart; there were no blocking errors

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@CharlVS CharlVS merged commit b563bdf into dev Mar 18, 2026
2 of 4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Visit the preview URL for this PR (updated for commit 46dc456):

https://komodo-playground--pr319-feat-sdk-pending-upd-0nb3gd8y.web.app

(expires Wed, 25 Mar 2026 17:20:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant