dds IRISTEST, NUCLEUSTEST & IRISTEST-IBC_NUCLEUSTEST as faucet coins#245
dds IRISTEST, NUCLEUSTEST & IRISTEST-IBC_NUCLEUSTEST as faucet coins#245
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Visit the preview URL for this PR (updated for commit a453d83): https://komodo-playground--pr245-add-tendermint-fauce-e17buy0e.web.app (expires Mon, 27 Oct 2025 08:37:54 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
|
Visit the preview URL for this PR (updated for commit a453d83): https://kdf-sdk--pr245-add-tendermint-fauce-bal6zv9s.web.app (expires Mon, 27 Oct 2025 08:39:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d |
takenagain
left a comment
There was a problem hiding this comment.
LGTM, thanks. I added a transitionary extension on AssetId to remove the duplication in komodo-wallet app_config.dart. We can also keep it simple for the release and copy over the list additions to komodo-wallet, as this list does not appear to have any references.
These are supported by https://faucet.komodo.earth/faucet_balances
The
IRISTEST-IBC_NUCLEUSTESTfaucet will be funded once https://github.com/KomodoPlatform/coins/pull/1552 is merged