Skip to content

dds IRISTEST, NUCLEUSTEST & IRISTEST-IBC_NUCLEUSTEST as faucet coins#245

Merged
CharlVS merged 2 commits intodevfrom
add/tendermint-faucet-coins
Oct 20, 2025
Merged

dds IRISTEST, NUCLEUSTEST & IRISTEST-IBC_NUCLEUSTEST as faucet coins#245
CharlVS merged 2 commits intodevfrom
add/tendermint-faucet-coins

Conversation

@smk762
Copy link
Copy Markdown
Contributor

@smk762 smk762 commented Oct 20, 2025

These are supported by https://faucet.komodo.earth/faucet_balances

The IRISTEST-IBC_NUCLEUSTEST faucet will be funded once https://github.com/KomodoPlatform/coins/pull/1552 is merged

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Oct 20, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add/tendermint-faucet-coins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@smk762 smk762 requested review from CharlVS and takenagain October 20, 2025 02:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2025

Visit the preview URL for this PR (updated for commit a453d83):

https://komodo-playground--pr245-add-tendermint-fauce-e17buy0e.web.app

(expires Mon, 27 Oct 2025 08:37:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 20, 2025

Visit the preview URL for this PR (updated for commit a453d83):

https://kdf-sdk--pr245-add-tendermint-fauce-bal6zv9s.web.app

(expires Mon, 27 Oct 2025 08:39:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d

Copy link
Copy Markdown
Contributor

@takenagain takenagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I added a transitionary extension on AssetId to remove the duplication in komodo-wallet app_config.dart. We can also keep it simple for the release and copy over the list additions to komodo-wallet, as this list does not appear to have any references.

@CharlVS CharlVS merged commit 1942840 into dev Oct 20, 2025
7 of 8 checks passed
@CharlVS CharlVS deleted the add/tendermint-faucet-coins branch October 20, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants