chore(framework): roll KDF staging to 4c4df13; update checksums#241
chore(framework): roll KDF staging to 4c4df13; update checksums#241
Conversation
Update api_commit_hash to 4c4df1326bcad6aa25ab837cad4fc84147e15084 and refresh valid_zip_sha256_checksums for web, iOS, macOS, Windows, Android (armv7, aarch64), and Linux.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the KDF (Komodo DeFi Framework) staging environment to commit 4c4df13 and refreshes all platform-specific artifact checksums for the build configuration.
- Update API commit hash from 8beb119 to 4c4df13 on staging branch
- Replace all valid ZIP SHA256 checksums for all supported platforms
- Consolidate checksum arrays from 2 entries to 1 entry per platform
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| "mac-arm64" | ||
| ], | ||
| "valid_zip_sha256_checksums": [ | ||
| "30550ace9e66a1303ce3295ccd14f73759ff8fb56396419bd2d1d6e2da2cf54e", | ||
| "595de272b14ac52c6ee71ab442d355fc7f37b4a92f09198b575e5c44b796393f" | ||
| "26f6f307f693e03c0456d5ae9c8fbd7ef267eca1a6dbb2b1b6fd4903e96c1fc3" | ||
| ], | ||
| "path": "macos/bin" | ||
| }, | ||
| "windows": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-win-x86-64|mm2_[a-f0-9]{7,40}-win-x86-64|mm2-[a-f0-9]{7,40}-Win64)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "db77335c8637d03e467c2cbb275ea4e57962ca22ed29542941f7105e5ba69e9a", | ||
| "619816f62bfd984abf0c2fb83d9efc3fea60b7a305fd912df0ee6c46ab376135" | ||
| "540b4438974de5abbb089efb65259a86bbd8a29ad093a16af41faf87785854a7" | ||
| ], |
There was a problem hiding this comment.
Keep checksums for all matching artifacts
The config still allows downloading both kdf_* and mm2_* archives (see the matching_pattern), but each platform’s valid_zip_sha256_checksums list now contains only a single hash. The download helper chooses the first asset matching the regex without preferring kdf over mm2 when no matching_preference is provided (update_api_config.dart::_fetchGithubDownloadUrl). If a release lists an mm2_* asset first—or only publishes the mm2_* variant—the checksum check will now reject that download and the build will fail. Keeping the second checksum (or restricting the regex to the artifact you intend to fetch) avoids breaking platforms whenever the release asset ordering changes.
Useful? React with 👍 / 👎.
|
Visit the preview URL for this PR (updated for commit 717fe64): https://komodo-playground--pr241-chore-roll-kdf-stagi-gvohiogy.web.app (expires Thu, 23 Oct 2025 15:42:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2bfedd77fdea45b25ba7c784416e81f177aa5c47 |
|
Visit the preview URL for this PR (updated for commit 717fe64): https://kdf-sdk--pr241-chore-roll-kdf-stagi-9vbsybru.web.app (expires Thu, 23 Oct 2025 15:43:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9c1b6e6c010cf0b965c455ba7a69c4aedafa8a1d |
This PR rolls the KDF API to commit 4c4df1326bcad6aa25ab837cad4fc84147e15084 on staging and updates the platform artifact checksums for web, iOS, macOS, Windows, Android (armv7, aarch64), and Linux.
Please run CI to publish new artifacts as needed.