feat(build): implement additional internal KDF hosting #236
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,61 @@ | ||
| { | ||
| "api": { | ||
| "api_commit_hash": "4025b8c", | ||
| "branch": "master", | ||
|
Collaborator
There was a problem hiding this comment. @smk762 KDF's default branch is Btw thanks for taking care of this :) |
||
| "fetch_at_build_enabled": true, | ||
| "concurrent_downloads_enabled": true, | ||
| "source_urls": [ | ||
| "https://api.github.com/repos/KomodoPlatform/komodo-defi-framework", | ||
| "https://sdk.devbuilds.komodo.earth/", | ||
| "https://nebula.decker.im/" | ||
| ], | ||
| "platforms": { | ||
| "web": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-wasm|mm2_[a-f0-9]{7,40}-wasm|mm2-[a-f0-9]{7,40}-wasm)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "d7cfd4dfa47f455ee283aa02c4dd11542b4bcf349928ec5b07a1f20b7141bd65" | ||
| ], | ||
| "path": "web/kdf/bin" | ||
| }, | ||
| "ios": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-ios-aarch64|mm2_[a-f0-9]{7,40}-ios-aarch64|mm2-[a-f0-9]{7,40}-ios-aarch64-CI)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "49c26280232fadbe456fbdd1dacc2cfd7697272202e59e41612691e50376a347" | ||
| ], | ||
| "path": "ios" | ||
| }, | ||
| "macos": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-mac-arm64|kdf-macos-universal2-[a-f0-9]{7,40}|mm2-[a-f0-9]{7,40}-Darwin-Release)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "30550ace9e66a1303ce3295ccd14f73759ff8fb56396419bd2d1d6e2da2cf54e" | ||
| ], | ||
| "path": "macos/bin" | ||
| }, | ||
| "windows": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-win-x86-64|mm2_[a-f0-9]{7,40}-win-x86-64|mm2-[a-f0-9]{7,40}-Win64)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "db77335c8637d03e467c2cbb275ea4e57962ca22ed29542941f7105e5ba69e9a" | ||
| ], | ||
| "path": "windows/bin" | ||
| }, | ||
| "android-armv7": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-android-armv7|mm2_[a-f0-9]{7,40}-android-armv7|mm2-[a-f0-9]{7,40}-android-armv7-CI)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "129f6f2467f14c9b7d9f7629d33d70197cb94b2237cbdb01a58e567a1b3260ee" | ||
| ], | ||
| "path": "android/app/src/main/cpp/libs/armeabi-v7a" | ||
| }, | ||
| "android-aarch64": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-android-aarch64|mm2_[a-f0-9]{7,40}-android-aarch64|mm2-[a-f0-9]{7,40}-android-aarch64-CI)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "00ea932edb7750c60c5d91705907b52ab018a7230f270a0f4286e41ee42cdf74" | ||
| ], | ||
| "path": "android/app/src/main/cpp/libs/arm64-v8a" | ||
| }, | ||
| "linux": { | ||
| "matching_pattern": "^(?:kdf_[a-f0-9]{7,40}-linux-x86-64|mm2_[a-f0-9]{7,40}-linux-x86-64|mm2-[a-f0-9]{7,40}-Linux-Release)\\.zip$", | ||
| "valid_zip_sha256_checksums": [ | ||
| "e25067ddb7b51455a109874722a595d7bc2ee4243ebd3af3e98426874d42f23d" | ||
| ], | ||
| "path": "linux/bin" | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -30,42 +30,64 @@ class DevBuildsArtefactDownloader implements ArtefactDownloader { | |||||
| ApiFileMatchingConfig matchingConfig, | ||||||
| String platform, | ||||||
| ) async { | ||||||
| // Try both branch-scoped and base-scoped listings to support different mirrors (devbuilds, Nebula, etc.) | ||||||
| final candidateListingUrls = <String>{ | ||||||
| // Typical devbuilds layout: <mirror>/<branch>/ | ||||||
| if (apiBranch.isNotEmpty) '$sourceUrl/$apiBranch/', | ||||||
| // Nebula may host a flat listing without branch segment | ||||||
| '$sourceUrl/', | ||||||
| }; | ||||||
|
|
||||||
| final extensions = ['.zip']; | ||||||
| final fullHash = apiCommitHash; | ||||||
| final shortHash = apiCommitHash.substring(0, 7); | ||||||
| _log.info('Looking for files with hash $fullHash or $shortHash'); | ||||||
|
|
||||||
| for (final listingUrl in candidateListingUrls) { | ||||||
| try { | ||||||
| final response = await http.get(Uri.parse(listingUrl)); | ||||||
| response.throwIfNotSuccessResponse(); | ||||||
| final document = parser.parse(response.body); | ||||||
|
|
||||||
| final attemptedFiles = <String>[]; | ||||||
| for (final element in document.querySelectorAll('a')) { | ||||||
| final href = element.attributes['href']; | ||||||
| if (href == null) continue; | ||||||
| attemptedFiles.add(href); | ||||||
|
|
||||||
| // Normalize href for directory indexes that include absolute paths | ||||||
| final fileName = path.basename(href); | ||||||
|
|
||||||
| // Ignore wallet archives on Nebula index | ||||||
| if (fileName.contains('wallet')) { | ||||||
| continue; | ||||||
| } | ||||||
|
|
||||||
| if (matchingConfig.matches(fileName) && | ||||||
| extensions.any(fileName.endsWith)) { | ||||||
| if (fileName.contains(fullHash) || fileName.contains(shortHash)) { | ||||||
| _log.info('Found matching file: $fileName at $listingUrl'); | ||||||
| // Build absolute URL respecting whether href is absolute or relative | ||||||
| final resolvedUrl = href.startsWith('http') | ||||||
| ? href | ||||||
| : path.join(listingUrl, fileName).replaceAll('\\', '/'); | ||||||
|
There was a problem hiding this comment. Using
Suggested change
|
||||||
| return resolvedUrl; | ||||||
| } | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| _log.fine( | ||||||
| 'No matching files found in $listingUrl. ' | ||||||
| '\nPattern: ${matchingConfig.matchingPattern}, ' | ||||||
| '\nHashes tried: [$fullHash, $shortHash]' | ||||||
| '\nAvailable assets: ${attemptedFiles.join('\n')}', | ||||||
| ); | ||||||
| } catch (e) { | ||||||
| _log.fine('Failed to query listing $listingUrl: $e'); | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| throw Exception('Zip file not found for platform $platform from $sourceUrl'); | ||||||
| } | ||||||
|
|
||||||
| @override | ||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit hash appears to be shortened to 7 characters while the branch changed from 'main' to 'master'. Ensure this commit actually exists on the master branch to avoid build failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smk762, this is a helpful idea to allow short commit hashes for the config updater script, but we can/should still require full commit hashes in the build config. Note that the build config updater script (ran in dev environment) is independent of the build step for fetching and downloading the KDF binaries.