Skip to content

perf(logs): reduce market metrics log verbosity and duplication #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 6 commits into from
Sep 19, 2025
Merged

perf(logs): reduce market metrics log verbosity and duplication #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d893fc4
perf(logs): reduce market metrics log verbosity and duplication
takenagain Sep 17, 2025
3c58cd4
refactor(market-metrics): add toUtc to startAt and remove duplicate log
takenagain Sep 17, 2025
0a4bc7f
test(runtime-coin-updates): update coinsubclass to smarchain for KMD
takenagain Sep 17, 2025
dd9ce71
Merge remote-tracking branch 'origin/dev' into perf/reduce-market-log…
takenagain Sep 18, 2025
72fddb1
chore: resolve merge issue
takenagain Sep 18, 2025
a619f0e
test(binance): remove legacy FRAX from the required USD mappings
takenagain Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions packages/komodo_cex_market_data/lib/src/binance/data/binance_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,24 +70,19 @@ class BinanceRepository implements CexRepository {

/// Internal method to fetch coin list data from the API.
Future<List<CexCoin>> _fetchCoinListInternal() async {
try {
// Try primary endpoint first, fallback to secondary on failure
Exception? lastException;
for (final baseUrl in binanceApiEndpoint) {
try {
final exchangeInfo = await _binanceProvider.fetchExchangeInfoReduced(
baseUrl: baseUrl,
);
return _convertSymbolsToCoins(exchangeInfo);
} catch (e) {
lastException = e is Exception ? e : Exception(e.toString());
}
Exception? lastException;
// Try primary endpoint first, fallback to secondary on failure
for (final baseUrl in binanceApiEndpoint) {
try {
final exchangeInfo = await _binanceProvider.fetchExchangeInfoReduced(
baseUrl: baseUrl,
);
return _convertSymbolsToCoins(exchangeInfo);
} catch (e) {
lastException = e is Exception ? e : Exception(e.toString());
}
throw lastException ?? Exception('All endpoints failed');
} catch (e, s) {
_logger.severe('Failed to fetch coin list from Binance API: $e', e, s);
rethrow;
}
throw lastException ?? Exception('All endpoints failed');
}

CexCoin _binanceCoin(String baseCoinAbbr, String quoteCoinAbbr) {
Expand Down
9 changes: 0 additions & 9 deletions packages/komodo_cex_market_data/lib/src/coingecko/data/coingecko_cex_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,15 +607,6 @@ class CoinGeckoCexProvider implements ICoinGeckoProvider {
response.body,
);

_logger.warning(
ApiErrorParser.createSafeErrorMessage(
operation: operation,
service: 'CoinGecko',
statusCode: response.statusCode,
coinId: coinId,
),
);

throw Exception(apiError.message);
}
}
234 changes: 82 additions & 152 deletions packages/komodo_cex_market_data/lib/src/coinpaprika/data/coinpaprika_cex_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,38 +106,23 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {

@override
Future<List<CoinPaprikaCoin>> fetchCoinList() async {
_logger.info('Fetching coin list from CoinPaprika');

final uri = Uri.https(baseUrl, '$apiVersion/coins');
try {
final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, 'ALL', 'coin list fetch');
}

final coins = jsonDecode(response.body) as List<dynamic>;
final result = coins
.cast<Map<String, dynamic>>()
.map(CoinPaprikaCoin.fromJson)
.toList();

_logger.info(
'Successfully fetched ${result.length} coins from CoinPaprika',
);
return result;
} on TimeoutException catch (e) {
_logger.severe('Timeout while fetching coin list from CoinPaprika', e);
throw TimeoutException(
'Request to fetch coin list timed out after ${CoinPaprikaConfig.timeout.inSeconds} seconds',
CoinPaprikaConfig.timeout,
);
} catch (e, st) {
_logger.severe('Failed to fetch coin list from CoinPaprika', e, st);
rethrow;

final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, 'ALL', 'coin list fetch');
}

final coins = jsonDecode(response.body) as List<dynamic>;
final result = coins
.cast<Map<String, dynamic>>()
.map(CoinPaprikaCoin.fromJson)
.toList();

return result;
}

/// Fetches historical OHLC data using the correct CoinPaprika API format.
Expand All @@ -164,12 +149,6 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
// Map quote currency: stablecoins -> underlying fiat (e.g., USDT -> USD)
final mappedQuote = _mapQuoteCurrencyForApi(quote);

_logger.fine(
'Fetching OHLC data for $coinId from ${_formatDateForApi(startDate)} '
'${endDate != null ? 'to ${_formatDateForApi(endDate)}' : ''} '
'(interval: $apiInterval, quote: ${mappedQuote.coinPaprikaId})',
);

// CoinPaprika API only requires start date and interval for historical data
final queryParams = <String, String>{
'start': _formatDateForApi(startDate),
Expand All @@ -184,42 +163,22 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
'$apiVersion/tickers/$coinId/historical',
queryParams,
);
try {
final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, coinId, 'OHLC data fetch');
}

final ticksData = jsonDecode(response.body) as List<dynamic>;
final result = ticksData
.cast<Map<String, dynamic>>()
.map(_parseTicksToOhlc)
.toList();

_logger.info(
'Successfully fetched ${result.length} OHLC data points for $coinId',
);
return result;
} on TimeoutException catch (e) {
_logger.severe(
'Timeout while fetching OHLC data for $coinId from CoinPaprika',
e,
);
throw TimeoutException(
'Request to fetch OHLC data for $coinId timed out after ${CoinPaprikaConfig.timeout.inSeconds} seconds',
CoinPaprikaConfig.timeout,
);
} catch (e, st) {
_logger.severe(
'Failed to fetch OHLC data for $coinId from CoinPaprika',
e,
st,
);
rethrow;

final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, coinId, 'OHLC data fetch');
}

final ticksData = jsonDecode(response.body) as List<dynamic>;
final result = ticksData
.cast<Map<String, dynamic>>()
.map(_parseTicksToOhlc)
.toList();

return result;
}

@override
Expand All @@ -232,7 +191,6 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
final quotesParam = mappedQuotes
.map((q) => q.coinPaprikaId.toUpperCase())
.join(',');
_logger.info('Fetching market data for $coinId with quotes: $quotesParam');

final queryParams = <String, String>{'quotes': quotesParam};

Expand All @@ -241,40 +199,22 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
'$apiVersion/coins/$coinId/markets',
queryParams,
);
try {
final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, coinId, 'market data fetch');
}

final markets = jsonDecode(response.body) as List<dynamic>;
final result = markets
.cast<Map<String, dynamic>>()
.map(CoinPaprikaMarket.fromJson)
.toList();

_logger.info('Successfully fetched ${result.length} markets for $coinId');
return result;
} on TimeoutException catch (e) {
_logger.severe(
'Timeout while fetching market data for $coinId from CoinPaprika',
e,
);
throw TimeoutException(
'Request to fetch market data for $coinId timed out after ${CoinPaprikaConfig.timeout.inSeconds} seconds',
CoinPaprikaConfig.timeout,
);
} catch (e, st) {
_logger.severe(
'Failed to fetch market data for $coinId from CoinPaprika',
e,
st,
);
rethrow;

final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, coinId, 'market data fetch');
}

final markets = jsonDecode(response.body) as List<dynamic>;
final result = markets
.cast<Map<String, dynamic>>()
.map(CoinPaprikaMarket.fromJson)
.toList();

return result;
}

/// Fetches ticker data for a specific coin.
Expand All @@ -291,41 +231,21 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
final quotesParam = mappedQuotes
.map((q) => q.coinPaprikaId.toUpperCase())
.join(',');
_logger.info('Fetching ticker data for $coinId with quotes: $quotesParam');

final queryParams = <String, String>{'quotes': quotesParam};

final uri = Uri.https(baseUrl, '$apiVersion/tickers/$coinId', queryParams);
try {
final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, coinId, 'ticker data fetch');
}
final ticker = jsonDecode(response.body) as Map<String, dynamic>;
final result = CoinPaprikaTicker.fromJson(ticker);
_logger.info('Successfully fetched ticker data for $coinId');
return result;
} on TimeoutException catch (e) {
_logger.severe(
'Timeout while fetching ticker data for $coinId from CoinPaprika',
e,
);
throw TimeoutException(
'Request to fetch ticker data for $coinId timed out after '
'${CoinPaprikaConfig.timeout.inSeconds} seconds',
CoinPaprikaConfig.timeout,
);
} catch (e, st) {
_logger.severe(
'Failed to fetch ticker data for $coinId from CoinPaprika',
e,
st,
);
rethrow;

final response = await _httpClient
.get(uri, headers: _createRequestHeaderMap())
.timeout(CoinPaprikaConfig.timeout);

if (response.statusCode != 200) {
_throwApiErrorOrException(response, coinId, 'ticker data fetch');
}
final ticker = jsonDecode(response.body) as Map<String, dynamic>;
final result = CoinPaprikaTicker.fromJson(ticker);
return result;
}

/// Validates if the requested date range is within the current API plan's
Expand All @@ -343,9 +263,11 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
}) {
// Validate interval support
if (!apiPlan.isIntervalSupported(interval)) {
throw ArgumentError(
throw ArgumentError.value(
interval,
'interval',
'Interval "$interval" is not supported in the ${apiPlan.planName} plan. '
'Supported intervals: ${apiPlan.availableIntervals.join(", ")}',
'Supported intervals: ${apiPlan.availableIntervals.join(", ")}',
);
}

Expand All @@ -360,22 +282,26 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {

// Check if any requested date is before the cutoff
if (startDate != null && startDate.isBefore(cutoffDate)) {
throw ArgumentError(
throw ArgumentError.value(
startDate,
'startDate',
'Historical data before ${_formatDateForApi(cutoffDate)} is not '
'available in the ${apiPlan.planName} plan. '
'Requested start date: ${_formatDateForApi(startDate)}. '
'${apiPlan.ohlcLimitDescription}. Please request more recent data or '
'upgrade your plan.',
'available in the ${apiPlan.planName} plan. '
'Requested start date: ${_formatDateForApi(startDate)}. '
'${apiPlan.ohlcLimitDescription}. Please request more recent data or '
'upgrade your plan.',
);
}

if (endDate != null && endDate.isBefore(cutoffDate)) {
throw ArgumentError(
throw ArgumentError.value(
endDate,
'endDate',
'Historical data before ${_formatDateForApi(cutoffDate)} is not '
'available in the ${apiPlan.planName} plan. '
'Requested end date: ${_formatDateForApi(endDate)}. '
'${apiPlan.ohlcLimitDescription}. Please request more recent data or '
'upgrade your plan.',
'available in the ${apiPlan.planName} plan. '
'Requested end date: ${_formatDateForApi(endDate)}. '
'${apiPlan.ohlcLimitDescription}. Please request more recent data or '
'upgrade your plan.',
);
}
}
Expand All @@ -385,10 +311,12 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
/// Throws [ArgumentError] if the interval is not supported.
void _validateInterval(String interval) {
if (!apiPlan.isIntervalSupported(interval)) {
throw ArgumentError(
throw ArgumentError.value(
interval,
'interval',
'Interval "$interval" is not supported in the ${apiPlan.planName} '
'plan. Supported intervals: ${apiPlan.availableIntervals.join(", ")}. '
'Please use a supported interval or upgrade to a higher plan.',
'plan. Supported intervals: ${apiPlan.availableIntervals.join(", ")}. '
'Please use a supported interval or upgrade to a higher plan.',
);
}
}
Expand Down Expand Up @@ -544,9 +472,11 @@ class CoinPaprikaProvider implements ICoinPaprikaProvider {
'${cutoffDate != null ? '(since ${_formatDateForApi(cutoffDate)})' : ''}',
);

throw ArgumentError(
throw ArgumentError.value(
response.body,
'apiResponse',
'Historical data not available: ${apiPlan.ohlcLimitDescription}. '
'Please request more recent data or upgrade your plan.',
'Please request more recent data or upgrade your plan.',
);
}

Expand Down
Loading
Loading