Skip to content

Fix coin activation format inconsistencies #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 1 commit into from
Aug 28, 2025
Merged

Fix coin activation format inconsistencies #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...thods/lib/src/common_structures/activation/activation_params/erc20_activation_params.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ class Erc20ActivationParams extends ActivationParams {

@override
JsonMap toRpcParams() => super.toRpcParams().deepMerge({
'nodes': nodes.map((e) => e.url).toList(),
// Align with KDF API which expects node objects (url/gui_auth), not plain strings
'nodes': nodes.map((e) => e.toJson()).toList(),
'swap_contract_address': swapContractAddress,
'fallback_swap_contract': fallbackSwapContract,
// Ensure priv_key_policy uses the structured JSON object for EVM
'priv_key_policy': privKeyPolicy?.toJson(),
Copy link
Copy Markdown

@cursor cursor Bot Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Missing privKeyPolicy in ERC20 Activation

The Erc20ActivationParams constructor doesn't accept privKeyPolicy, causing it to be null or an uninitialized default when toRpcParams() is called. This prevents custom private key policies from being applied to ERC20 activations.

Fix in Cursor Fix in Web

});
}
2 changes: 1 addition & 1 deletion ...thods/lib/src/common_structures/activation/activation_params/zhtlc_activation_params.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class ZhtlcActivationParams extends ActivationParams {
required super.mode,
super.requiredConfirmations,
super.requiresNotarization = false,
super.privKeyPolicy = PrivateKeyPolicy.contextPrivKey,
super.privKeyPolicy = const PrivateKeyPolicy.contextPrivKey(),
super.minAddressesNumber,
super.scanPolicy,
super.gapLimit,
Expand Down
4 changes: 2 additions & 2 deletions ...ges/komodo_defi_sdk/lib/src/activation/protocol_strategies/zhtlc_activation_strategy.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ class ZhtlcActivationStrategy extends ProtocolActivationStrategy {

try {
final protocol = asset.protocol as ZhtlcProtocol;
final params = ActivationParams.fromConfigJson(protocol.config)
.genericCopyWith(
final params = ZhtlcActivationParams.fromConfigJson(protocol.config)
.copyWith(
scanBlocksPerIteration: 200,
scanIntervalMs: 200,
zcashParamsPath: protocol.zcashParamsPath,
Expand Down
Loading