Fix melos publish blocking issues#202
Merged
CharlVS merged 1 commit intofix/upgrade-depsfrom Aug 21, 2025
Merged
Conversation
…itories Co-authored-by: charl <charl@vanstaden.info>
|
Cursor Agent can help with this pull request. Just |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses publication blocking issues in a Flutter monorepo by standardizing package metadata, adding required licenses, and resolving dependency configuration problems for pub.dev publishing.
- Replace local path dependencies with hosted package references
- Add MIT license files to all packages for publication compliance
- Standardize repository URLs and remove trailing slashes
- Add missing dependencies and loosen Flutter version constraints
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/komodo_wallet_cli/pubspec.yaml | Add missing runtime dependencies and remove dev dependency reference |
| packages/komodo_wallet_cli/LICENSE | Add MIT license for publication |
| packages/komodo_wallet_cli/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_wallet_build_transformer/pubspec.yaml | Fix repository URL and add yaml dependency |
| packages/komodo_wallet_build_transformer/LICENSE | Add MIT license for publication |
| packages/komodo_wallet_build_transformer/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_ui/pubspec.yaml | Loosen Flutter constraints and switch to hosted dependencies |
| packages/komodo_ui/LICENSE | Add MIT license for publication |
| packages/komodo_symbol_converter/pubspec.yaml | Add repository URL for publication |
| packages/komodo_symbol_converter/LICENSE | Add MIT license for publication |
| packages/komodo_symbol_converter/CHANGELOG.md | Add initial changelog for publication |
| packages/komodo_defi_types/pubspec.yaml | Fix repository URL, loosen Flutter constraints, and switch to hosted dependencies |
| packages/komodo_defi_types/LICENSE | Add MIT license for publication |
| packages/komodo_defi_types/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_defi_sdk/pubspec.yaml | Switch all internal dependencies to hosted packages and pin logging version |
| packages/komodo_defi_sdk/LICENSE | Add MIT license for publication |
| packages/komodo_defi_sdk/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_defi_rpc_methods/pubspec.yaml | Switch to hosted dependencies and fix repository field |
| packages/komodo_defi_rpc_methods/LICENSE | Add MIT license for publication |
| packages/komodo_defi_rpc_methods/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_defi_local_auth/pubspec.yaml | Switch to hosted dependencies and loosen Flutter constraints |
| packages/komodo_defi_local_auth/LICENSE | Add MIT license for publication |
| packages/komodo_defi_framework/pubspec.yaml | Switch to hosted dependencies and loosen Flutter constraints |
| packages/komodo_coins/pubspec.yaml | Fix homepage URL and switch to hosted dependencies |
| packages/komodo_coins/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_coin_updates/pubspec.yaml | Switch to hosted dependencies and loosen version constraints |
| packages/komodo_coin_updates/LICENSE | Add MIT license for publication |
| packages/komodo_coin_updates/CHANGELOG.md | Update version and changelog for publication |
| packages/komodo_cex_market_data/pubspec.yaml | Switch to hosted dependencies and add repository URL |
| packages/komodo_cex_market_data/LICENSE | Add MIT license for publication |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Missing Transformer Dependency Causes Build Failures
The komodo_wallet_build_transformer dependency was removed from dev_dependencies but is still referenced in the assets.transformers section. This will cause build failures, especially when the package is used outside the monorepo, as the transformer won't be available.
packages/komodo_wallet_cli/pubspec.yaml#L35-L46
| komodo_defi_local_auth: any | ||
| komodo_defi_rpc_methods: any | ||
| komodo_defi_types: any | ||
| komodo_ui: any |
There was a problem hiding this comment.
Bug: Monorepo Dependencies Use Unconstrained Versions
Internal monorepo dependencies are using any version constraints. This allows any version to be resolved, which can lead to compatibility issues, unpredictable behavior, and version conflicts, especially when these packages are published.
Additional Locations (2)
CharlVS
added a commit
that referenced
this pull request
Aug 22, 2025
* chore: upgrade all packages * fix: resolve deps issues for products * chore: regen runners * chore(workspace): migrate to Dart Pub workspaces and inline Melos config\n\n- Add workspace members in root pubspec per Melos migration guide\n- Add resolution: workspace to all packages\n- Remove melos.yaml and move config under root pubspec\n\nRefs: https://melos.invertase.dev/guides/migrations * chore(workspace): finalize migration to Pub workspaces\n\n- Bump Dart SDK constraints to >=3.9.0 across all packages\n- Remove legacy pubspec_overrides.yaml files\n- Validate workspace integrity (no per-package overrides)\n\nRefs: https://melos.invertase.dev/guides/migrations * chore!: unify Dart SDK (^3.9.0) and Flutter (>=3.35.0 <3.36.0) constraints across workspace - Update playground and products pubspecs - Normalize root workspace SDK format to caret Refs: https://melos.invertase.dev/guides/migrations * chore: commit updated pubspec and lockfiles after workspace migration * chore: bump dex_dungeons pubspec.lock * chore(pub): remove publish bypass * Prepare packages for publishing: update deps, add licenses, and repositories (#202) Co-authored-by: Cursor Agent <cursoragent@cursor.com> * fix(deps): resolve deps error * fix(deps): misc deps fixes * chore(git): untrack files now ignored by .gitignore (fvm config, transformer invoker, example firebase and kdf bootstrapper) * fix: pub submission errors * fix(pub): add non-generic description * chore: pin internal mono-repo deps to caret ranges and bootstrap * chore(release): publish packages - dragon_charts_flutter@0.1.1-dev.2 - dragon_logs@1.2.1 - komodo_cex_market_data@0.0.2+1 - komodo_coin_updates@1.0.1 - komodo_coins@0.3.0+1 - komodo_defi_framework@0.3.0+1 - komodo_defi_local_auth@0.3.0+1 - komodo_defi_rpc_methods@0.3.0+1 - komodo_defi_sdk@0.3.0+1 - komodo_defi_types@0.3.0+2 - komodo_symbol_converter@0.3.0+1 - komodo_ui@0.3.0+1 - komodo_wallet_build_transformer@0.3.0+1 - komodo_wallet_cli@0.3.0+1 * Update Dart SDK version constraint to support future versions Co-authored-by: charl <charl@vanstaden.info> * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * docs(changelog): remove accidental 'melos version' command; normalize bullets/spacing in dragon_charts_flutter CHANGELOG --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve all identified issues blocking package publication in the monorepo.