Integrate and verify ZHTLC in komodo_defi_sdk#196
Merged
CharlVS merged 2 commits intocursor/integrate-zhtlc-types-and-rpcs-4654from Aug 21, 2025
Conversation
Co-authored-by: charl <charl@vanstaden.info>
|
Cursor Agent can help with this pull request. Just |
Contributor
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: charl <charl@vanstaden.info>
CharlVS
merged commit e61dc52
into
cursor/integrate-zhtlc-types-and-rpcs-4654
2 of 6 checks passed
CharlVS
deleted the
cursor/integrate-and-verify-zhtlc-in-komodo-defi-sdk-823b
branch
CharlVS
added a commit
that referenced
this pull request
Oct 2, 2025
* Enhance ZHTLC activation with improved config parsing and RPC methods Co-authored-by: charl <charl@vanstaden.info> * feat(zhtlc): integrate ZHTLC types and task RPCs per KDF API * dragon_logs: remove tracked ignored files and add .gitignore files * Integrate and verify ZHTLC in komodo_defi_sdk (#196) * Refactor ZHTLC activation strategy with stream-based task handling Co-authored-by: charl <charl@vanstaden.info> * Refactor activation steps to use strongly-typed ActivationStep enum Co-authored-by: charl <charl@vanstaden.info> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * chore: run code generators * chore(git): delete previously tracked igored files * Fix ERC20 and ZHTLC activation params serialization and method calls (#212) Co-authored-by: Cursor Agent <cursoragent@cursor.com> * fix: misc fixes * docs(activation): add activation params refactoring plan Clean base/subclass separation, canonical serialization + encoder strategy, user configuration + persistence, BLoC timeout, SDK integration via AssetId extension and resolveActivationParams, and migration steps. No backwards compatibility required. * docs(sdk): activation refactoring v2 * feat(activation,zhtlc,sdk,rpc)!: extract ZHTLC fields to ZhtlcActivationParams; add ActivationConfigService; unify priv_key_policy serialization; normalize toRpcParams; formatting fixes * Checkpoint before follow-up message Co-authored-by: charl <charl@vanstaden.info> * Fix: Remove unused import statement Co-authored-by: charl <charl@vanstaden.info> * feat: Add support for electrum_servers in Zhtlc activation Co-authored-by: charl <charl@vanstaden.info> * feat: initialize Firebase hosting for SDK example and playground - Add Firebase hosting configuration for packages/komodo_defi_sdk/example - Configure to use kdf-sdk hosting site on komodo-defi-sdk project - Set up hosting target mapping - Add Firebase hosting configuration for playground - Configure to use default hosting site on komodo-playground project - Update GitHub Actions workflows to use target parameter for SDK example - Update .gitignore to allow Firebase config files in example and playground * fix: update z-coin activation strategy and example UI - Update zhtlc_activation_strategy for improved activation handling - Add activation config service enhancements - Update logged_in_view_widget with improved UI for instance management - Export additional SDK functionality in public API * docs(firebase): reorganize Firebase deployment scripts and documentation - Move Firebase scripts to .github/scripts/firebase/ directory - Rename scripts for clarity: - setup-firebase-secrets.sh → setup-github-secrets.sh - verify-firebase-secrets.sh → verify-github-secrets.sh - Move documentation to docs/firebase/ directory - Rename documentation file to firebase-deployment-setup.md - Update script paths in documentation - Add README for scripts directory * fix: remove global singleton registration of ActivationConfigService - Remove global GetIt.I registration to prevent conflicts between multiple SDK instances - Pass ActivationConfigService through constructor chain instead of global resolution - Update ZhtlcActivationStrategy to accept service via constructor - Update ActivationStrategyFactory and ActivationManager to propagate the service - Prevent memory leaks and use-after-dispose issues when SDK instances are disposed This ensures each SDK instance maintains its own isolated ActivationConfigService, fixing issues where only the first SDK's service would be globally registered. * fix(activation): register ActivationConfigService during bootstrap - Ensure service is available before ActivationManager to fix ZHTLC/Z-coin activation flow\n- Remove duplicate registration from KomodoDefiSdk.init\n- Example: use instance sdk instead of context.read for ZHTLC prompt * docs(tech-debt): add Activation & ZHTLC tech-debt report and refine sections * feat(komodo_defi_sdk): add HiveActivationConfigRepository and integrate in activation flow; update bootstrap, activation service, and example widget * fix: resolve external logging callback flaws and memory leak - Fix native callback memory leak by disposing _kdfOperations in KomodoDefiFramework - Remove debug-only conditional logging in bootstrap.dart - Fix potential double subscription in komodo_defi_sdk.dart - Add comprehensive error handling to log stream listeners - Replace empty catch blocks with proper error handling - Add safe logging helpers to prevent callback exceptions from crashing - Ensure log streams continue operating even after callback errors * refactor(withdrawals): inject LegacyWithdrawalManager and use for Tendermint flows - add _legacyManager constructor param and field - delegate Tendermint preview/withdraw to injected manager - minor formatting and watch() simplifications * fix(kdf-ops): use conditional imports for platform-specific imports i.e. dart:ffi * fix(activation-params): include other RPC server keys * fix(activation-config-repository): register adapter type * feat(zhtlc): add desktop zcash params downloader (#228) * feat(sdk): add zhltc params file downloader * feat(sdk-example): integrate zcash downloader for desktop * chore: remove groth from default params download list * test(komodo-defi-sdk): fix failing zcash unit tests * refactor: clean up imports, tests, and dialog date conversion * feat(zhtlc): add mobile config params downloader * feat(zhtlc): web lightwallet server URLs workaround * fix(zhtlc): align orderbook RPC with KDF schema, and add id pagination support (#229) * feat(zhtlc-tx): add from_id pagination support from RPC docs * fix(orderbook-v2): use v2 fields and types * fix(source-address-field): use consistent text theme to fix visibility * fix(order-address): change address data to optional for shielded ops * fix(json-utils): convert int to string in traverse as it's lossless * test(sdk): fix missing type in zcash mock classes * fix(address-select-input): use consistent text theme to fix visibility * feat(zhtlc): estimate activation percentage based on block height (#230) * feat(zhtlc): estimate activation percentage based on block height * refactor(review): remove unnecessary casts, states, and configurable polling * fix(config-transform): only replace lightwalletservers if wss is not empty * Fix ZHTLC activation issues and improve resilience Co-authored-by: charl <charl@vanstaden.info> --------- Co-authored-by: Charl (Nitride) <77973576+CharlVS@users.noreply.github.com> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: charl <charl@vanstaden.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ZHTLC activation to use the dedicated
zhtlcRPC namespace andTaskShepherdfor robust task management and accurate block reporting.