Skip to content

fix(sdk): stop KDF before disposing managers #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CharlVS merged 1 commit into from
Jul 7, 2025
Merged

fix(sdk): stop KDF before disposing managers #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/komodo_defi_sdk/lib/src/komodo_defi_sdk.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,16 @@ class KomodoDefiSdk with SecureRpcPasswordMixin {
: KomodoDefiLocalAuth.storedAuthOptions(user.walletId.name);
}

Future<void> _disposeIfRegistered<T>(Future<void> Function(T) fn) async {
if (_container.isRegistered<T>()) {
try {
await fn(_container<T>());
} catch (e) {
log('Error disposing $T: $e');
}
}
}

/// Disposes of this SDK instance and cleans up all resources.
///
/// This should be called when the SDK is no longer needed to ensure proper
Expand All @@ -333,6 +343,7 @@ class KomodoDefiSdk with SecureRpcPasswordMixin {
_isDisposed = true;
if (!_isInitialized) return;
_isInitialized = false;
_initializationFuture = null;

if (stopKdf) {
try {
Expand All @@ -343,6 +354,17 @@ class KomodoDefiSdk with SecureRpcPasswordMixin {
}
}

await Future.wait([
_disposeIfRegistered<KomodoDefiLocalAuth>((m) => m.dispose()),
_disposeIfRegistered<AssetManager>((m) => m.dispose()),
_disposeIfRegistered<ActivationManager>((m) => m.dispose()),
_disposeIfRegistered<BalanceManager>((m) => m.dispose()),
_disposeIfRegistered<PubkeyManager>((m) => m.dispose()),
_disposeIfRegistered<TransactionHistoryManager>((m) => m.dispose()),
_disposeIfRegistered<MarketDataManager>((m) => m.dispose()),
_disposeIfRegistered<WithdrawalManager>((m) => m.dispose()),
]);

// Reset scoped container
await _container.reset();

Expand Down
Loading