Skip to content

Fix asset overlay for child assets #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takenagain merged 1 commit into from
Jul 2, 2025
Merged

Fix asset overlay for child assets #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/komodo_defi_types/lib/src/assets/asset_id.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ class AssetId extends Equatable {
};

@override
List<Object?> get props => [id, subClass.formatted];
List<Object?> get props => [id, subClass.formatted, chainId.formattedChainId];

@override
String toString() =>
Expand Down
9 changes: 6 additions & 3 deletions packages/komodo_ui/lib/src/defi/asset/asset_logo.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,12 @@ class AssetLogo extends StatelessWidget {
final resolvedTicker = _legacyTicker;
final resolvedSubClass = asset?.protocol.subClass ?? assetId?.subClass;

final protocolTicker = resolvedSubClass?.iconTicker;
final shouldShowProtocolIcon =
resolvedSubClass != null && resolvedSubClass != CoinSubClass.utxo;
final isChildAsset = resolvedId?.isChildAsset ?? false;

// Use the parent coin ticker for child assets so that token logos display
// the network they belong to (e.g. ETH for ERC20 tokens).
final protocolTicker = isChildAsset ? resolvedId?.parentId?.id : null;
final shouldShowProtocolIcon = isChildAsset && protocolTicker != null;

final mainIcon =
resolvedId != null
Expand Down
Loading