Cancel the kickstarted order immediately if balance is not sufficient.#992
Merged
artemii235 merged 2 commits intodevfrom Jun 29, 2021
Merged
Cancel the kickstarted order immediately if balance is not sufficient.#992artemii235 merged 2 commits intodevfrom
artemii235 merged 2 commits intodevfrom
Conversation
|
I thought the balance checking is performed on |
Author
|
Yes, it fails because a balance check is performed once per 10 seconds - an order is broadcast to the network during this time and can be matched leading to errors described in the issue. |
shamardy
reviewed
Jun 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#973