Skip to content

SLP integration WIP.#977

Merged
artemii235 merged 14 commits intodevfrom
mm2.1-slp
Jun 16, 2021
Merged

SLP integration WIP.#977
artemii235 merged 14 commits intodevfrom
mm2.1-slp

Conversation

@artemii235
Copy link
Copy Markdown

# Conflicts:
#	mm2src/coins/utxo/utxo_tests.rs
Copy link
Copy Markdown

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no blockers, just a few comments that can be solved in the next iteration

Comment thread mm2src/coins/utxo/utxo_common.rs Outdated
Comment thread mm2src/coins/utxo/slp.rs Outdated
Comment thread mm2src/coins/utxo/slp.rs
Comment thread mm2src/coins/utxo/slp.rs Outdated
Comment thread mm2src/coins/utxo/slp.rs Outdated
shamardy
shamardy previously approved these changes Jun 11, 2021
Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@artemii235 artemii235 dismissed stale reviews from shamardy and sergeyboyko0791 via 524e29f June 15, 2021 12:54
@artemii235
Copy link
Copy Markdown
Author

@sergeyboyko0791 I've pushed the update, please recheck the PR 🙂

Copy link
Copy Markdown

@sergeyboyko0791 sergeyboyko0791 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread mm2src/coins/z_coin.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants