Return KMD rewards amount for all KMD txs #874#965
Merged
artemii235 merged 11 commits intodevfrom Jun 9, 2021
Merged
Conversation
sergeyboyko0791
commented
Jun 3, 2021
sergeyboyko0791
commented
- Add 'kmd_rewards' to TransactionDetails returning from withdraw, my_tx_history
* TODO fill the 'kmd_rewards' filed in UtxoCoin::withdraw
Author
|
There is one nuance regarding the transaction history. Do we have to re-request the KMD transaction history to recalculate the fees and KMD rewards? |
* Add 'get_mut_verbose_transaction_from_map_or_rpc', 'calc_interest_of_tx' to 'UtxoCommonOps' * Add 'update_kmd_rewards' to 'UtxoStandardOps'
sergeyboyko0791
requested review from
shamardy
and removed request for
artemii235 and
shamardy
artemii235
reviewed
Jun 8, 2021
artemii235
left a comment
artemii235
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have one minor comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.