Skip to content

fix(sia-txhist): assign internal ids to sia transaction details #2691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mariocynicys merged 1 commit into from
Nov 20, 2025
+6 −3
Merged

fix(sia-txhist): assign internal ids to sia transaction details #2691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions mm2src/coins/siacoin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,6 +2004,7 @@ impl SiaCoin {
match &event.data {
EventDataWrapper::V2Transaction(tx) => {
let txid = tx.txid().to_string();
let internal_id = hex::decode(&txid).map_to_mm(|e| e.to_string())?.into();

let from: Vec<String> = tx
.siacoin_inputs
Expand Down Expand Up @@ -2067,14 +2068,15 @@ impl SiaCoin {
.into(),
),
coin: self.ticker().to_string(),
internal_id: vec![].into(),
internal_id,
kmd_rewards: None,
transaction_type: TransactionType::SiaV2Transaction,
memo: None,
})
},
EventDataWrapper::V1Transaction(tx) => {
let txid = tx.transaction.txid().to_string();
let internal_id = hex::decode(&txid).map_to_mm(|e| e.to_string())?.into();

let from: Vec<String> = tx
.spent_siacoin_elements
Expand Down Expand Up @@ -2150,14 +2152,15 @@ impl SiaCoin {
.into(),
),
coin: self.ticker().to_string(),
internal_id: vec![].into(),
internal_id,
kmd_rewards: None,
transaction_type: TransactionType::SiaV1Transaction,
memo: None,
})
},
EventDataWrapper::MinerPayout(event_payout) | EventDataWrapper::FoundationPayout(event_payout) => {
let txid = event_payout.siacoin_element.id.to_string();
let internal_id = hex::decode(&txid).map_to_mm(|e| e.to_string())?.into();

let from: Vec<String> = vec![];

Expand Down Expand Up @@ -2191,7 +2194,7 @@ impl SiaCoin {
timestamp: event.timestamp.timestamp() as u64,
fee_details: None,
coin: self.ticker().to_string(),
internal_id: vec![].into(),
internal_id,
kmd_rewards: None,
transaction_type: TransactionType::SiaMinerPayout,
memo: None,
Expand Down
Loading