Skip to content

fix(sse): fix broken client id parsing logic #2677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onur-ozkan merged 1 commit into from
Oct 31, 2025
Merged

fix(sse): fix broken client id parsing logic #2677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions mm2src/mm2_net/src/event_streaming/sse_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,13 @@ pub async fn handle_sse(request: Request<Body>, ctx_h: u32) -> Response<Body> {
return handle_internal_error("Event streaming is disabled".to_string()).await;
};

let client_id = match request.uri().query().and_then(|query| {
query
.split('&')
.find(|param| param.starts_with("id="))
.map(|id_param| id_param.trim_start_matches("id=").parse::<u64>())
}) {
Some(Ok(id)) => id,
let client_id = request
.uri()
.query()
.and_then(|q| q.split('&').find_map(|p| p.strip_prefix("id=")))
.and_then(|v| v.parse::<u64>().ok())
// Default to zero when client ID isn't passed, most of the cases we will have a single user/client.
_ => 0,
};
.unwrap_or(0);

let event_stream_manager = ctx.event_stream_manager.clone();
let Ok(mut rx) = event_stream_manager.new_client(client_id) else {
Expand Down
Loading