Skip to content

fix(core): handle streamer error gracefully #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
onur-ozkan merged 1 commit into from
Oct 28, 2025
Merged

fix(core): handle streamer error gracefully #2669

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions mm2src/mm2_main/src/mm2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,9 +245,14 @@ fn spawn_os_signal_handler(ctx: MmArc) {
_ => format!("UNKNOWN({signal})"),
};

ctx.event_stream_manager
// This fails if the streamer has no active listeners,
// but we can safely ignore any failure here.
if let Err(e) = ctx
.event_stream_manager
.send(&mm2_event_stream::StreamerId::ShutdownSignal, signal_name.clone())
.unwrap();
{
log::debug!("Failed to send the SHUTDOWN_SIGNAL event: {e:?}");
}

if signals_to_handle.contains(&signal) {
log::info!("Received {signal_name} signal from the OS. Wrapping things up and shutting down...");
Expand Down
Loading