fix(tests): fix/remove kmd rewards failing test#2633
Merged
Conversation
by removing it xD the test: `test_update_kmd_rewards_claimed_not_by_me`
onur-ozkan
reviewed
Oct 6, 2025
mm2src/coins/lp_coins.rs
Outdated
Comment on lines
2496
to
2498
| /// Note that we don't have a case where this boolean is set to false. | ||
| /// It persists here though for backward compatibility and potential future use cases. | ||
| claimed_by_me: bool, |
There was a problem hiding this comment.
Let's just remove the field IMO. The BC is nothing like a big deal (people can simply remove it from their use-case). I am not even sure if there is a real-user depending on this field.
Collaborator
Author
There was a problem hiding this comment.
agreed, we better remove it all together.
cc/ @shamardy what do u think? and we can edit method names to de-reflect that claimed_by_me field.
Collaborator
There was a problem hiding this comment.
I am fine with removing it
and adapt usages, tests, and test description
shamardy
approved these changes
Oct 6, 2025
onur-ozkan
approved these changes
Oct 6, 2025
dimxy
pushed a commit
that referenced
this pull request
Oct 8, 2025
* dev: fix(TPU): correct dexfee in check balance to prevent swap failures (#2600) fix(tests): fix/remove kmd rewards failing test (#2633) chore(ci): bump CI container image to debian bullseye-slim to match dev (#2641) chore(release): add changelog entries for v2.5.2-beta (#2639) chore(release): bump mm2 version to 2.5.2-beta (#2638) feat(ci): add macos universal2 build (#2628) fix(metrics): remove memory_db size metric (#2632) chore(rust 1.90): make CI clippy/fmt pass Revert "fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580)" Revert "fix(orderbook): validate roots before commit (#2605)"
dimxy
pushed a commit
that referenced
this pull request
Oct 9, 2025
* dev: fix(TPU): correct dexfee in check balance to prevent swap failures (#2600) fix(tests): fix/remove kmd rewards failing test (#2633) chore(ci): bump CI container image to debian bullseye-slim to match dev (#2641) chore(release): add changelog entries for v2.5.2-beta (#2639) chore(release): bump mm2 version to 2.5.2-beta (#2638) feat(ci): add macos universal2 build (#2628) fix(metrics): remove memory_db size metric (#2632) fix(zcoin): exact-anchor witnesses in wasm get_spendable_notes (#2629) fix(evm-swapv2): no mempool inclusion required for maker payment validation (#2618) chore(rust 1.90): make CI clippy/fmt pass Revert "fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580)" Revert "fix(orderbook): validate roots before commit (#2605)"
dimxy
pushed a commit
that referenced
this pull request
Oct 15, 2025
`test_update_kmd_rewards_claimed_not_by_me` was removed while un-ignoring two other tests that provide coverage for kmd rewards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since the test was already duplicated of the other one above it (test_update_kmd_rewards) but only has the
fromaddresses manually changed to trigger settingclaimed_by_me: false, the test was removed all together.noteably, we don't have a usecase ever where we get
claimed_by_meis set tofalse. not internally, nor via the RPC. leaving the field though just for backward combatability and future extensions (maybe?).also, unignored two other tests.