forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 117
feat(protocol): [0] solana support #2586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4f88ec1
create solana module
onur-ozkan e5bd9a2
partially add bare structure
onur-ozkan 758e444
add more infra to solana support
onur-ozkan 291acda
and more infra for solana
onur-ozkan e7bb84f
add place-holder types on solana activation
onur-ozkan 203e2c7
feature gate solana implementation
onur-ozkan 6085ac4
Merge branch 'dev' of github.com:KomodoPlatform/komodo-defi-framework…
onur-ozkan 42212e9
bless clippy
onur-ozkan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| mod solana_coin; | ||
|
|
||
| pub use solana_coin::SolanaCoin; | ||
| pub use solana_coin::SolanaInitError; | ||
| pub use solana_coin::SolanaProtocolInfo; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I remembered that shortens the time for you in the future is to add Solana here https://github.com/KomodoPlatform/komodo-defi-framework/blob/6085ac4fa847245e4730b97d4cac7937401df567/mm2src/coins/lp_coins.rs#L3865-L3878
Or just move this function to a trait and remove this default implementation. This is of course for next PRs. Hope there is no other things like this that I forgot about, but checking default trait implementations can help you, if not, you will find out while testing for sure.