-
Notifications
You must be signed in to change notification settings - Fork 117
fix(DOCS): add note for macos to fix docker containers startup failure #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,11 @@ | |
| ``` | ||
| 9. Try `cargo test --all --features run-docker-tests -- --test-threads=16`. | ||
|
|
||
| Note for MacOS users: | ||
| - The UTXO 'testblockchain' docker container may fail to start due to TCP port conflict with MacOS AirPlay Receiver (using the same 7000 port). Disabling AirPlay Receiver resolves this problem. | ||
|
|
||
| - The 'nucleusd' test docker container (and the dependent 'ibc-relayer' container) may fail to start on MacOS. The MacOS docker "Enable host networking" option may help with this issue. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would re-write this part as: "nucleusd container (along with the dependent ibc-relayer container) requires host network access, but on MacOS, by default containers can not access to host network. Therefore, the "Enable host networking" option must be enabled to allow the nucleusd containers to run properly"
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dimxy feel free to open another PR for these changes if you want. I guess I merged this a bit early |
||
|
|
||
| ## Running WASM tests | ||
|
|
||
| 1. Set up [WASM Build Environment](../docs/WASM_BUILD.md#Setting-up-the-environment) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we not changing the container port instead of telling users to disable AirPlay 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could suggest the user to change the port by themselves, as another option
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not changing the container port directly on KDF? That way users don't have to change or know anything about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may change it ofc, no guarantee though that there would not conflicts with other services.
We may rephrase the note as more general like: if containers do not start check for port conflicts, for example for MacOS it may be a conflict with AirPlay