feat(eth): improve gas fee policy code by dimxy · Pull Request #2533 · GLEECBTC/komodo-defi-framework

dimxy · 2025-07-16T07:08:07Z

This PR adds a few fixes and improvements in handling gas fee policy:

fix getting max_eth_tx_type from the platform coin config: first it gets this param from the platform coin conf then from the token conf.
adds new params to the coins file for adjustment of gas price and eip1559 fee per gas:

            "gas_price_adjust": {
                "legacy_price_mult": 0.25,
                "base_fee_mult": [0.1, 0.2, 0.3],
                "priority_fee_mult": [0.4, 0.5, 0.6]
            },

Those params allow to adjust legacy or priority gas price for specific EVM coins or tokens. First the params are searched in the token config, if none, then in the platform coin config (cc @cipig).

renamed the "set_swap_transaction_fee_policy" RPC in "set_swap_gas_fee_policy" and store the gas policy value always in the EVM platform coin. This renamed RPC is a BREAKING CHANGE.
allow to use the gas fee policy set by the "set_swap_gas_fee_policy" RPC in the sign_raw_tx call (needed for signing LR txns with the same policy used in atomic swaps)
added an optional param swap_gas_fee_policy to the enable (if EVM) and enable_eth_with_tokens RPCs. The swap_gas_fee_policy param can have the values: Legacy, Low, Medium and High. The param is relevant only for the platform coin.
refactored gas policy enums to simplify them.
refactor: renamed fn's like wei_from_big_decimal into u256_from_big_decimal bcs this conversion is used not only for wei but for token smallest units as well.

More fixes added:

removed minimal value of 1 gwei for the gas price (see the updated increase_by_percent fn) to allow BNB low fees
add check for the ticker to match the "coin" value in the coin conf for the legacy "enable" RPC
fix nonce lock (mutex use) to prevent duplicate nonces if the legacy "enable" RPC used to activate tokens - fixes this issue: Replacement transaction underpriced error for Maker payment spend transaction #2573
added a new estimate_gas_mult param to the coins file. If it is set to some floating point value, then eth_estimateGas RPC will be used to get gas limit for swap transactions. The received gas limit value will be also adjusted by multiplying by the estimate_gas_mult value (therefore recommended to set it to value > 1.0).

This PR is also preliminary for the upcoming new liquidity routing feature.

…s fee adjust coin params, rename "set_swap_transaction_fee_policy" rpc to "set_swap_gas_fee_policy", force set_swap_gas_fee_policy to store policy in the platform coin

… in tests)

cipig · 2025-07-16T09:54:10Z

How can i set eip1559 for all enabled tokens without having to call "set_swap_transaction_fee_policy" for each of them in part? I want to avoid this since i have several dozen tokens...
Can i pass "set_swap_transaction_fee_policy" in the enable_eth_with_tokens call, which btw looks like this:

curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"enable_eth_with_tokens\",\"mmrpc\":\"2.0\",\"params\":{\"get_balances\":false,\"ticker\":\"POL\",\"mm2\":1,\"priv_key_policy\":{\"type\":\"ContextPrivKey\"},\"swap_contract_address\":\"0x9130b257D37A52E52F21054c4DA3450c72f595CE\",\"fallback_swap_contract\":\"0x9130b257D37A52E52F21054c4DA3450c72f595CE\",\"nodes\":[{\"url\":\"https://electrum3.cipig.net:18755\"},{\"url\":\"https://polygon-bor-rpc.publicnode.com\"}],\"tx_history\":false,\"erc20_tokens_requests\":[{\"ticker\":\"1INCH-PLG20\"},{\"ticker\":\"AAVE-PLG20\"},{\"ticker\":\"AGEUR-PLG20\"},{\"ticker\":\"ANKR-PLG20\"},{\"ticker\":\"APE-PLG20\"},{\"ticker\":\"ARPA-PLG20\"},{\"ticker\":\"ATOM-PLG20\"},{\"ticker\":\"BAL-PLG20\"},{\"ticker\":\"BRZ-PLG20\"},{\"ticker\":\"CADC-PLG20\"},{\"ticker\":\"COMP-PLG20\"},{\"ticker\":\"CRV-PLG20\"},{\"ticker\":\"DAI-PLG20\"},{\"ticker\":\"ETH-PLG20\"},{\"ticker\":\"EURE-PLG20\"},{\"ticker\":\"EUROE-PLG20\"},{\"ticker\":\"EURS-PLG20\"},{\"ticker\":\"FXS-PLG20\"},{\"ticker\":\"GLM-PLG20\"},{\"ticker\":\"GMT-PLG20\"},{\"ticker\":\"GNS-PLG20\"},{\"ticker\":\"GRT-PLG20\"},{\"ticker\":\"HEX-PLG20\"},{\"ticker\":\"IDRT-PLG20\"},{\"ticker\":\"JAUD-PLG20\"},{\"ticker\":\"JBRL-PLG20\"},{\"ticker\":\"JCAD-PLG20\"},{\"ticker\":\"JCHF-PLG20\"},{\"ticker\":\"JCNY-PLG20\"},{\"ticker\":\"JEUR-PLG20\"},{\"ticker\":\"JGBP-PLG20\"},{\"ticker\":\"JGOLD-PLG20\"},{\"ticker\":\"JJPY-PLG20\"},{\"ticker\":\"JKRW-PLG20\"},{\"ticker\":\"JMXN-PLG20\"},{\"ticker\":\"JNZD-PLG20\"},{\"ticker\":\"JPLN-PLG20\"},{\"ticker\":\"SYN-PLG20\"},{\"ticker\":\"JSGD-PLG20\"},{\"ticker\":\"JTRY-PLG20\"},{\"ticker\":\"SPACE-PLG20\"},{\"ticker\":\"JPYC-PLG20\"},{\"ticker\":\"KNC-PLG20\"},{\"ticker\":\"LDO-PLG20\"},{\"ticker\":\"LINK-PLG20\"},{\"ticker\":\"MANA-PLG20\"},{\"ticker\":\"MASK-PLG20\"},{\"ticker\":\"MKR-PLG20\"},{\"ticker\":\"NEXO-PLG20\"},{\"ticker\":\"PGX-PLG20\"},{\"ticker\":\"PAXG-PLG20\"},{\"ticker\":\"POT-PLG20\"},{\"ticker\":\"PYR-PLG20\"},{\"ticker\":\"REQ-PLG20\"},{\"ticker\":\"RNDR-PLG20\"},{\"ticker\":\"SAND-PLG20\"},{\"ticker\":\"SHIB-PLG20\"},{\"ticker\":\"SNX-PLG20\"},{\"ticker\":\"SOL-PLG20\"},{\"ticker\":\"SUSHI-PLG20\"},{\"ticker\":\"TBTC-PLG20\"},{\"ticker\":\"TEL-PLG20\"},{\"ticker\":\"DFX-PLG20\"},{\"ticker\":\"TRYB-PLG20\"},{\"ticker\":\"UNI-PLG20\"},{\"ticker\":\"OM-PLG20\"},{\"ticker\":\"USDT-PLG20\"},{\"ticker\":\"WBTC-PLG20\"},{\"ticker\":\"WOO-PLG20\"},{\"ticker\":\"YFI-PLG20\"},{\"ticker\":\"XIDR-PLG20\"},{\"ticker\":\"XSGD-PLG20\"}]}}"

can i also use this in the old enable call? i need to use the old enable call, because i need to use other RPC endpoints for the base coin then for all others... eg like here for USDC-PLG20

curl --url "http://127.0.0.1:7783" --data "{\"userpass\":\"$userpass\",\"method\":\"enable\",\"coin\":\"USDC-PLG20\",\"urls\":[\"https://electrum3.cipig.net:18755\",\"https://polygon.lava.build\"],\"swap_contract_address\":\"0x9130b257D37A52E52F21054c4DA3450c72f595CE\",\"fallback_swap_contract\":\"0x9130b257D37A52E52F21054c4DA3450c72f595CE\"}"

i can't use the same endpoints because kdf does lots of requests to the RPC endpoints and if i use the same for both tokens of a pair in orderbook, it will be too slow and public endpoints also tend to block you or slow you down if you send too many requests

dimxy · 2025-07-16T15:35:23Z

Can i pass "set_swap_transaction_fee_policy" in the enable_eth_with_tokens call, which btw looks like this:

Yes, I forgot to mention this in this PR description, added: there is a swap_gas_fee_policy param.
Note that if it is passed in the 'enable' RPC for a ERC20 it will be ignored as the gas fee policy now is always taken from the platform coin. Maybe I should return a error if swap_gas_fee_policy param is used for a ERC20 enable call.

cipig · 2025-07-17T01:19:01Z

Note that if it is passed in the 'enable' RPC for a ERC20 it will be ignored as the gas fee policy now is always taken from the platform coin.

So, in my example from above, what will happen if i pass swap_gas_fee_policy to both calls, or just to the first one, the enable_eth_with_tokens?
Since the platform coin is enabled first, together with a bunch of tokens, what happens to the fees of USDC-PLG20, which is enabled later with the simple enable call? Will USDC-PLG20 use the swap_gas_fee_policy of the parent coin if that is passed in the enable_eth_with_tokens call?

shamardy · 2025-07-17T09:33:30Z

Since the platform coin is enabled first, together with a bunch of tokens, what happens to the fees of USDC-PLG20, which is enabled later with the simple enable call?

Didn't look at the code yet, but how it worked before is that tokens inherit from platform in v2 activations, so you need to use enable_erc20 RPC

cipig · 2025-07-17T09:50:34Z

Didn't look at the code yet, but how it worked before is that tokens inherit from platform in v2 activations, so you need to use enable_erc20 RPC

I can't use v2 activation for the base coin, in this case USDC-PLG20 because i need to use other RPC endpoints for the base coin then for all other PLG20 tokens. If i use the same public server for both, it will not work, i need to spread the load over several distinct servers.
The only solution i found for this is to use enable_eth_with_tokens for POL and all tokens and enable for USDC-PLG20 (or whatever the PLG20 base coin is on that maker node).

dimxy · 2025-07-18T06:18:27Z

Since the platform coin is enabled first, together with a bunch of tokens, what happens to the fees of USDC-PLG20, which is enabled later with the simple enable call? Will USDC-PLG20 use the swap_gas_fee_policy of the parent coin if that is passed in the enable_eth_with_tokens call?

Yes, in this PR the gas fee policy is stored only in the platform coin (MATIC) so for USDC-PLG20 and any other token one and the same policy will be used. I think, this is consistent.
I may return an error if set_swap_gas_fee_policy rpc is used for a non-platform token.

cipig · 2025-07-22T06:32:02Z

switched to this branch for testing and the console is flooded with entries like this

pay_for_gas=Ok(Legacy { gas_price: 25000000120 })
pay_for_gas=Ok(Legacy { gas_price: 3000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })

how can i disable them?

shamardy · 2025-07-22T06:41:29Z

switched to this branch for testing and the console is flooded with entries like this

pay_for_gas=Ok(Legacy { gas_price: 25000000120 })
pay_for_gas=Ok(Legacy { gas_price: 3000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })
pay_for_gas=Ok(Legacy { gas_price: 1000000000 })

how can i disable them?

Will remove this println now, it was done for testing by @dimxy I suppose

- remove another println

shamardy · 2025-07-22T06:55:38Z

Sorry about asking you to try with this PR @cipig , it's still in progress. @dimxy I pushed 2 commits, feel free to remove them if you want.

shamardy · 2025-07-22T07:01:12Z

there is one debug output left, i now get this all the time: get_swap_pay_for_gas_option get_eip1559_gas_fee result=FeePerGasEstimated { base_fee: 0, low: FeePerGasLevel { max_priority_fee_per_gas: 100000000, max_fee_per_gas: 100000000, min_wait_time: None, max_wait_time: None }, medium: FeePerGasLevel { max_priority_fee_per_gas: 110000000, max_fee_per_gas: 110000000, min_wait_time: None, max_wait_time: None }, high: FeePerGasLevel { max_priority_fee_per_gas: 110000000, max_fee_per_gas: 110000000, min_wait_time: None, max_wait_time: None }, source: Simple, base_fee_trend: "", priority_fee_trend: "" }

Already removed here ea071a8 :)

dimxy · 2025-07-22T07:37:51Z

Sorry I forgot to remove println's
Thank you for the fix @shamardy

cipig · 2025-07-22T07:40:06Z

i used this in RPC call set_swap_gas_fee_policy and also with the enable_eth_with_tokens and both worked
question: can i use swap_gas_fee_policy in coins file too? and if so, would it break older kdf versions if i add it and they don't "understand" it? for BNB and all BEP20 tokens using "Low" is fine, it then uses 0.11 gwei, while 0.1 gwei is their fixed gas price atm, so we could actually add it to coins file directly

dimxy · 2025-07-22T07:55:40Z

can i use swap_gas_fee_policy in coins file too?

I can add this param to the coins file as well. It should not break old kdf's.
Added @cipig.

onur-ozkan

Thanks!

Some notes from my side after the initial review:

onur-ozkan · 2025-07-22T07:30:41Z

mm2src/coins/eth/eth_utils.rs

+const MAX_ETH_TX_TYPE_SUPPORTED: &str = "max_eth_tx_type";
+const LEGACY_GAS_PRICE_MULTIPLIER: &str = "gas_price_mult";
+const GAS_FEE_BASE_ADJUST: &str = "gas_fee_base_adjust";
+const GAS_FEE_PRIORITY_ADJUST: &str = "gas_fee_priority_adjust";


What are these? I haven't looked at the use cases of them but it shouldn't be necessary to do that just to know what they are. An example, the one that called LEGACY_GAS_PRICE_MULTIPLIER implies it's a multiplier but it's a plain string value. It's worth to document them (or give an explicit/clear name).

onur-ozkan · 2025-07-22T07:38:29Z

mm2src/coins/eth/eth_utils.rs

+            if let Some(val) = get_conf_param(conf, param)? {
+                Ok(Some(val))
+            } else {
+                get_conf_param(&coin_conf(ctx, platform), param)
+            }


You can use or/or_else.

onur-ozkan · 2025-07-22T07:40:32Z

mm2src/coins/eth/eth_utils.rs

+    fn get_conf_param(conf: &Json, param: &str) -> Result<Option<Json>, String> {
+        if !conf[param].is_null() {
+            Ok(Some(conf[param].clone()))
+        } else {
+            Ok(None)
+        }
+    }


Why is it returning Result? You could also use get on conf and remove is_null and Some/None dances.

onur-ozkan · 2025-07-22T07:44:48Z

mm2src/coins/eth/eth_utils.rs

+    match get_conf_param_or_from_plaform(ctx, conf, MAX_ETH_TX_TYPE_SUPPORTED, coin_type) {
+        Ok(Some(val)) => {
+            let max_eth_tx_type = val
+                .as_u64()
+                .ok_or_else(|| format!("{MAX_ETH_TX_TYPE_SUPPORTED} in coins is invalid"))?;
+            if max_eth_tx_type > ETH_MAX_TX_TYPE {
+                return Err(format!("{MAX_ETH_TX_TYPE_SUPPORTED} in coins is too big"));
+            }
+            Ok(Some(max_eth_tx_type))
+        },
+        Ok(None) => Ok(None),
+        Err(err) => Err(err),


The Err(err) => Err(err) part isn't necessary. You can do match get_conf_param_or_from_plaform(ctx, conf, MAX_ETH_TX_TYPE_SUPPORTED, coin_type)? and match on Some and None directly.

This applies to all the other functions below.

onur-ozkan · 2025-07-22T07:51:34Z

mm2src/coins/eth/eth_utils.rs

+            let gas_price_mult = val
+                .as_f64()
+                .ok_or_else(|| format!("{LEGACY_GAS_PRICE_MULTIPLIER} in coins is invalid"))?;
+            if gas_price_mult <= 0.0 {
+                return Err(format!("{LEGACY_GAS_PRICE_MULTIPLIER} in coins is negative"));


Should we create a good first issue for validating the coins file on the fly using proper types instead of relying on plain Json values and validating fields on demand? Using proper types would allow the coins file to be automatically validated at KDF startup.

We could also reject unknown fields to help keep the file clean and up to date.

cc @shamardy

There is this #1995
ref. #1995 (comment)

onur-ozkan · 2025-07-22T07:55:17Z

mm2src/coins/nft.rs

                Some(gas_price) => EthTxFeeDetails::new(
                    gas_used,
-                    PayForGasOption::Legacy(LegacyGasPrice { gas_price }),
+                    PayForGasOption::Legacy { gas_price }, // TODO: is this always legacy?


nit:

Suggested change

PayForGasOption::Legacy { gas_price }, // TODO: is this always legacy?

// TODO: is this always legacy?

PayForGasOption::Legacy { gas_price },

onur-ozkan · 2025-07-22T07:57:39Z

mm2src/coins/lp_coins.rs

+    /// Use legacy gas price
    #[default]
-    Unsupported,
-    Internal,
+    Legacy,


What does "legacy gas price" mean? Could you elaborate the comment a bit more?

Added more doc comments (btw Legacy means pre-EIp1559)

shamardy · 2025-07-22T09:11:46Z

for BNB and all BEP20 tokens using "Low" is fine, it then uses 0.11 gwei, while 0.1 gwei is their fixed gas price atm

This is due to this https://github.com/KomodoPlatform/komodo-defi-framework/blob/6bd2a172999220bb10e4973e3b860df02a85b5eb/mm2src/coins/eth.rs#L6734-L6745
Do we still need this increase @dimxy ?

P.S. it should be fixed in this other PR #2454 if it needs fixing

Edit: nevermind as I saw this https://github.com/KomodoPlatform/komodo-defi-framework/blob/6bd2a172999220bb10e4973e3b860df02a85b5eb/mm2src/coins/eth.rs#L6731 Why the increase then as when I tried using withdraw it used exactly 0.1 gwei for low priority

…ram in activation request overrides it

… const and gas variants,

dimxy · 2025-07-22T18:01:28Z

fixed @onur-ozkan notes, tyvm 0788385

… mutex (to prevent dup nonce in enable legacy rpc)

…_transaction fn

* dev: (24 commits) fix(ordermatch): ignore loop-back; clear on null root; reject stale keep-alives (#2580) fix(clippy): fix clippy warnings for #2565 (#2589) fix(Trezor): fix utxo and eth calls due to firmware changes (#2565) fix(utxo): calculate min_trading_vol based on fixed tx fees (#2564) feat(protocol): [0] solana support (#2586) fix(utxo): fix header deserialization; guard AuxPoW (#2583) chore(rust 1.89): make CI clippy/fmt pass (wasm32, all-targets) (#2581) fix(utxo): deserialize sapling root for PIVX block headers (#2572) improvement(dep-stack): security bumps (#2562) fix(utxo): correct block header deserialization for AuxPow and KAWPOW coins (#2563) feat(wallet-connect): impl BTC (UTxO) activation via WalletConnect (#2499) feat(utxo): add new fixed txfee option for DINGO-like coins (#2454) ci(pull-requests): review notification bot (#2468) improvement(walletconnect): return the `pairing_topic` in `new_connection` response (#2538) bless clippy (#2560) refactor(toolchain): use latest available stable compiler (#2557) feat(wallet): implement unified offline private key export API (#2542) improve note for docker test start failure (#2550) fix(DOCS): add note for macos to fix docker containers startup failure (#2544) refactor(toolchain): general stabilization for stable rust (#2528) ... # Conflicts: # mm2src/coins/eth.rs # mm2src/coins/eth/eth_swap_v2/eth_maker_swap_v2.rs # mm2src/coins/eth/eth_swap_v2/eth_taker_swap_v2.rs # mm2src/coins/eth/eth_tests.rs # mm2src/coins/eth/eth_withdraw.rs # mm2src/coins/eth/v2_activation.rs # mm2src/coins/nft.rs # mm2src/coins/qrc20.rs # mm2src/mm2_main/src/rpc/dispatcher/dispatcher.rs # mm2src/mm2_main/src/rpc/lp_commands/one_inch/rpcs.rs # mm2src/mm2_main/src/rpc/lp_commands/tokens.rs # mm2src/mm2_main/tests/docker_tests/eth_docker_tests.rs

dimxy · 2025-08-15T18:06:39Z

Merged latest dev.
Also removed the refactoring code breaking eth.rs into more sources - for a later dedicated PR, for easier review @shamardy

* dev: fix build script failing to find .git/HEAD (#2601) refactor(EVM): rename fn, fix timeouts, add activation req validation (#2543) improvement(`static mut`s): `static mut` removal (#2590) fix(orders): set subscription on kickstart and skip GC of own pubkeys (#2597) # Conflicts: # mm2src/coins/eth.rs

shamardy

Next review iteration, most of these comments are non blockers.

mm2src/coins/eth/eth_withdraw.rs

shamardy · 2025-08-27T21:29:09Z

mm2src/coins/eth/eth_withdraw.rs

                ))?;
                let gas_price = pay_for_gas_option.get_gas_price();
                let (max_fee_per_gas, max_priority_fee_per_gas) = pay_for_gas_option.get_fee_per_gas();
+                // TODO: we should get _nonce_lock here (when WalletConnect is supported for swaps)


Swaps are already supported for WalletConnect, I suppose it works the same way as metamask if we pass nonce as None. But we use our internal nonce fetching logic here https://github.com/KomodoPlatform/komodo-defi-framework/blob/093afd5280e678562743d22ae37c4e96725fe59e/mm2src/coins/eth/wallet_connect.rs#L286 so I think we should do this for WC asap c.c. @mariocynicys

In the future, we should make nonce usage configurable for metamask and WC, the config option should be about if we should let the connected wallets decide it or not, it can be paired with the broadcast parameter or separate from it.

mm2src/coins/lp_coins.rs

mm2src/coins/eth.rs

shamardy · 2025-08-27T23:42:14Z

mm2src/coins/eth.rs

-                    .await
-            );
-
-            coin.sign_and_send_transaction(0.into(), Call(token_addr), data, gas_limit)


This used to use the estimate without the multiplier but it will now use it even if it was meant for other things, is this acceptable?

I removed this call as redundant, to always use estimate_gas_for_contract_call_if_conf.
Indeed, estimate_gas_for_contract_call_if_conf will apply the multiplier, if it is set. I thought it's okay to use multiplier for all calls, including 'approve'

mm2src/coins/eth.rs

shamardy · 2025-08-27T23:47:58Z

mm2src/coins/eth.rs

+    if conf["coin"].as_str() != Some(ticker) {
+        return ERR!("Failed to activate '{}': ticker does not match coins config", ticker);
+    }


Just curious why we needed this

Actually I added this for sanity check in tests (when I used this fn to enable many coins and messed with configs/tickers).
If fact, we can eliminate the ticker param and get it from the conf param in all coin enable functions.

…in param

This commit does the following: - Adds SwapGasFeePolicy (Legacy/EIP-1559) stored on the platform coin; tokens inherit it - Supports GasPriceRpcParam in sign_raw_transaction (uses policy or explicit Legacy/EIP-1559 fees) - Adds gas_price_adjust (legacy/base/priority) and estimate_gas_mult; token→platform fallback; same for max_eth_tx_type - enable and enable_eth_with_tokens accept swap_gas_fee_policy (platform coin only) - Renames wei_from_big_decimal → u256_from_big_decimal; removes 1 gwei minimum bump; validates enable ticker vs conf - Replaces global nonce lock with per-network, per-address locks BREAKING CHANGE: renames RPCs get/set_swap_transaction_fee_policy → get/set_swap_gas_fee_policy

dimxy added 4 commits July 15, 2025 22:22

Refactor gas fee code: get max_eth_tx_type from platform coin, add ga…

6e906de

…s fee adjust coin params, rename "set_swap_transaction_fee_policy" rpc to "set_swap_gas_fee_policy", force set_swap_gas_fee_policy to store policy in the platform coin

revert tokio test and use block_on for eth docker test

3b711cc

fix(test) disable get_swap_gas_fee_policy for tests (no platform coin…

a510c03

… in tests)

revert change in test_enable_custom_erc20

3af3863

dimxy added status: in progress priority: medium Moderately important tasks that should be completed but are not urgent. breaking-change: RPC labels Jul 16, 2025

onur-ozkan self-requested a review July 22, 2025 05:00

shamardy mentioned this pull request Jul 22, 2025

gas price lower then 1 gwei not possible #2475

Closed

shamardy added 2 commits July 22, 2025 09:43

remove pay_for_gas println

673f559

fix wasm, fmt and clippy

ea071a8

- remove another println

onur-ozkan reviewed Jul 22, 2025

View reviewed changes

cipig mentioned this pull request Jul 22, 2025

Implement EVM priority fees GLEECBTC/gleec-wallet#2977

Open

dimxy added 2 commits July 22, 2025 21:34

add swap_gas_fee_policy coin config for platform coin (only), same pa…

da74c98

…ram in activation request overrides it

review (onur-ozkan): refactor getting conf params, add doc for config…

0788385

… const and gas variants,

dimxy added 5 commits August 15, 2025 21:01

fix/refactor nonce lock: wrap the original locks-per-network map with…

69bf9b1

… mutex (to prevent dup nonce in enable legacy rpc)

add docker test for dup nonce

d1ddbfe

cargo fmt

605be7c

add call to estimate_gas_for_contract_call_if_conf() in sign_and_send…

d1a626c

…_transaction fn

dimxy force-pushed the refactor-gas-fee-policy branch from 934f4e1 to 093afd5 Compare August 15, 2025 17:54

dimxy marked this pull request as ready for review August 21, 2025 17:06

cipig mentioned this pull request Aug 27, 2025

fix ARB20 fees GLEECBTC/coins#1491

Merged

shamardy reviewed Aug 27, 2025

View reviewed changes

dimxy added 13 commits August 29, 2025 15:57

refactor(review): remove extra default_gas param

433e913

remove extra cfg_attr for test code

6e4effb

removed for now unused estimate_trade_fee

88f9fdb

removed extra info logs

70383b6

refactor (review): add GetSwapGasFeePolicyRequest struct with only co…

bcf18d2

…in param

fix doc comment

ed5a454

refactor: remove extra option level in result

50f2ed5

removed unneeded TODO

8b31eac

added check in legacy activation to match ticker to conf for other coins

83c1a17

fix(test): add "coin" in test conf

f088337

fix(tests): add coin in qtum test conf

f885ae3

fix(tests) more "coin" added to test conf

de74dcf

fix(tests): another ticker name fix

66b8a65

shamardy added the status: pending docs Adding this label will automatically open an issue in the docs repo label Sep 6, 2025

shamardy approved these changes Sep 6, 2025

View reviewed changes

shamardy merged commit ea91c0d into dev Sep 6, 2025
20 of 27 checks passed

shamardy deleted the refactor-gas-fee-policy branch September 6, 2025 04:31

shamardy mentioned this pull request Nov 25, 2025

chore(release): v2.6.0-beta #2696

Merged

	PayForGasOption::Legacy { gas_price }, // TODO: is this always legacy?
	// TODO: is this always legacy?
	PayForGasOption::Legacy { gas_price },

Conversation

dimxy commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipig commented Jul 16, 2025

Uh oh!

dimxy commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cipig commented Jul 17, 2025

Uh oh!

shamardy commented Jul 17, 2025

Uh oh!

cipig commented Jul 17, 2025

Uh oh!

dimxy commented Jul 18, 2025

Uh oh!

cipig commented Jul 22, 2025

Uh oh!

shamardy commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shamardy commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shamardy commented Jul 22, 2025

Uh oh!

dimxy commented Jul 22, 2025

Uh oh!

cipig commented Jul 22, 2025

Uh oh!

dimxy commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

onur-ozkan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shamardy Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shamardy commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimxy commented Jul 22, 2025

Uh oh!

dimxy commented Aug 15, 2025

Uh oh!

shamardy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dimxy Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

dimxy commented Jul 16, 2025 •

edited

Loading

dimxy commented Jul 16, 2025 •

edited

Loading

shamardy commented Jul 22, 2025 •

edited

Loading

shamardy commented Jul 22, 2025 •

edited

Loading

dimxy commented Jul 22, 2025 •

edited

Loading

shamardy Jul 22, 2025 •

edited

Loading

shamardy commented Jul 22, 2025 •

edited

Loading

dimxy Sep 1, 2025 •

edited

Loading