Skip to content

test(electrums): fix failing test_one_unavailable_electrum_proto_version #2412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shamardy merged 2 commits into from
Apr 11, 2025
Merged

test(electrums): fix failing test_one_unavailable_electrum_proto_version #2412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b80823
ignore failing test_one_unavailable_electrum_proto_version
shamardy Apr 11, 2025
d7a542e
actually fix using an unrealistically high version
shamardy Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions mm2src/coins/utxo/utxo_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1601,7 +1601,7 @@ fn test_spam_rick() {

#[test]
fn test_one_unavailable_electrum_proto_version() {
// Patch the electurm client construct to require protocol version 1.4 only.
// First mock with an unrealistically high version requirement that no server would support
ElectrumClientImpl::try_new_arc.mock_safe(
|client_settings, block_headers_storage, streaming_manager, abortable_system, event_handlers| {
MockResult::Return(ElectrumClientImpl::with_protocol_version(
Expand All @@ -1610,16 +1610,17 @@ fn test_one_unavailable_electrum_proto_version() {
streaming_manager,
abortable_system,
event_handlers,
OrdRange::new(1.4, 1.4).unwrap(),
OrdRange::new(7.4, 7.4).unwrap(),
))
},
);
// check if the electrum-mona.bitbank.cc:50001 doesn't support the protocol version 1.4
let client = electrum_client_for_test(&["electrum-mona.bitbank.cc:50001"]);

// Try to connect with the high version requirement - should fail
let client = electrum_client_for_test(&["electrum1.cipig.net:10000"]);
// When an electrum server doesn't support our protocol version range, it gets removed by the client,
// wait a little bit to make sure this is the case.
block_on(Timer::sleep(2.));
let error = block_on_f01(client.get_block_count_from("electrum-mona.bitbank.cc:50001"))
let error = block_on_f01(client.get_block_count_from("electrum1.cipig.net:10000"))
.unwrap_err()
.to_string();
log!("{}", error);
Expand All @@ -1628,11 +1629,24 @@ fn test_one_unavailable_electrum_proto_version() {
drop(client);
log!("Run BTC coin to test the server.version loop");

// Now reset the mock to a supported version
ElectrumClientImpl::try_new_arc.mock_safe(
|client_settings, block_headers_storage, streaming_manager, abortable_system, event_handlers| {
MockResult::Return(ElectrumClientImpl::with_protocol_version(
client_settings,
block_headers_storage,
streaming_manager,
abortable_system,
event_handlers,
OrdRange::new(1.4, 1.4).unwrap(),
))
},
);

let conf = json!({"coin":"BTC","asset":"BTC","rpcport":8332});
let req = json!({
"method": "electrum",
// electrum-mona.bitbank.cc:50001 supports only 1.2 protocol version
"servers": [{"url":"electrum1.cipig.net:10000"},{"url":"electrum-mona.bitbank.cc:50001"}],
"servers": [{"url":"electrum1.cipig.net:10000"}],
});

let ctx = MmCtxBuilder::new().into_mm_arc();
Expand Down
Loading