fix(tx-history): token information and query

mm2src/coins/lp_coins.rs

@@ -2426,7 +2426,9 @@ pub enum TransactionType {
         token_id: Option<BytesJson>,
     },
     NftTransfer,
-    TendermintIBCTransfer,
+    TendermintIBCTransfer {
+        token_id: Option<BytesJson>,
+    },
 }
 
 /// Transaction details

mm2src/coins/my_tx_history_v2.rs

@@ -1,5 +1,6 @@
 use crate::hd_wallet::{AddressDerivingError, DisplayAddress, InvalidBip44ChainError};
-use crate::tendermint::{TENDERMINT_ASSET_PROTOCOL_TYPE, TENDERMINT_COIN_PROTOCOL_TYPE};
+use crate::tendermint::{BCH_COIN_PROTOCOL_TYPE, BCH_TOKEN_PROTOCOL_TYPE, TENDERMINT_ASSET_PROTOCOL_TYPE,
+                        TENDERMINT_COIN_PROTOCOL_TYPE};
 use crate::tx_history_storage::{CreateTxHistoryStorageError, FilteringAddresses, GetTxHistoryFilters,
                                 TxHistoryStorageBuilder, WalletId};
 use crate::utxo::utxo_common::big_decimal_from_sat_unsigned;
@@ -209,7 +210,8 @@ impl<'a, Addr: Clone + DisplayAddress + Eq + std::hash::Hash, Tx: Transaction> T
                 bytes_for_hash.extend_from_slice(&token_id.0);
                 sha256(&bytes_for_hash).to_vec().into()
             },
-            TransactionType::CustomTendermintMsg { token_id, .. } => {
+            TransactionType::TendermintIBCTransfer { token_id }
+            | TransactionType::CustomTendermintMsg { token_id, .. } => {
                 if let Some(token_id) = token_id {
                     let mut bytes_for_hash = tx_hash.0.clone();
                     bytes_for_hash.extend_from_slice(&token_id.0);
@@ -223,8 +225,7 @@ impl<'a, Addr: Clone + DisplayAddress + Eq + std::hash::Hash, Tx: Transaction> T
             | TransactionType::ClaimDelegationRewards
             | TransactionType::FeeForTokenTx
             | TransactionType::StandardTransfer
-            | TransactionType::NftTransfer
-            | TransactionType::TendermintIBCTransfer => tx_hash.clone(),
+            | TransactionType::NftTransfer => tx_hash.clone(),
         };
 
         TransactionDetails {
@@ -414,11 +415,6 @@ where
         .transactions
         .into_iter()
         .map(|mut details| {
-            // it can be the platform ticker instead of the token ticker for a pre-saved record
-            if details.coin != request.coin {
-                details.coin = request.coin.clone();
-            }
-
             // TODO
             // !! temporary solution !!
             // for tendermint, tx_history_v2 implementation doesn't include amount parsing logic.
@@ -468,6 +464,16 @@ where
                         },
                     }
                 },
+                BCH_COIN_PROTOCOL_TYPE | BCH_TOKEN_PROTOCOL_TYPE => {
+                    // SLP tokens are part of BCH transactions and SLP transactions might be stored with the BCH ticker.
+                    // Ideally, we should avoid this workaround and instead fix the incorrect ticker logic when inserting
+                    // transactions with the wrong ticker.
+                    //
+                    // Original PR: https://github.com/KomodoPlatform/komodo-defi-framework/pull/1175.
+                    if details.coin != request.coin {
+                        details.coin = request.coin.clone();
+                    }
+                },
                 _ => {},
             };
 

mm2src/coins/tendermint/mod.rs

@@ -16,5 +16,7 @@ pub use cosmrs::AccountId;
 pub use tendermint_coin::*;
 pub use tendermint_token::*;
 
+pub(crate) const BCH_COIN_PROTOCOL_TYPE: &str = "BCH";
+pub(crate) const BCH_TOKEN_PROTOCOL_TYPE: &str = "SLPTOKEN";
 pub(crate) const TENDERMINT_COIN_PROTOCOL_TYPE: &str = "TENDERMINT";
 pub(crate) const TENDERMINT_ASSET_PROTOCOL_TYPE: &str = "TENDERMINTTOKEN";

mm2src/coins/tendermint/tendermint_coin.rs

@@ -170,6 +170,8 @@ impl RpcNode {
 
 #[async_trait]
 pub trait TendermintCommons {
+    fn denom_to_ticker(&self, denom: &str) -> Option<String>;
+
     fn platform_denom(&self) -> &Denom;
 
     fn set_history_sync_state(&self, new_state: HistorySyncState);
@@ -620,6 +622,21 @@ impl TendermintCommons for TendermintCoin {
         Ok(u64::try_from(timestamp.seconds).ok())
     }
 
+    fn denom_to_ticker(&self, denom: &str) -> Option<String> {
+        if self.denom.as_ref() == denom {
+            return Some(self.ticker.clone());
+        }
+
+        let ctx = MmArc::from_weak(&self.ctx)?;
+
+        ctx.conf["coins"].as_array()?.iter().find_map(|coin| {
+            coin["protocol"]["protocol_data"]["denom"]
+                .as_str()
+                .filter(|&d| d.to_lowercase() == denom.to_lowercase())
+                .and_then(|_| coin["coin"].as_str().map(|s| s.to_owned()))
+        })
+    }
+
     async fn get_all_balances(&self) -> MmResult<AllBalancesResult, TendermintCoinRpcError> {
         let platform_balance_denom = self
             .account_balance_for_denom(&self.account_id, self.denom.to_string())
@@ -3162,7 +3179,7 @@ impl MmCoin for TendermintCoin {
                 internal_id,
                 kmd_rewards: None,
                 transaction_type: if is_ibc_transfer {
-                    TransactionType::TendermintIBCTransfer
+                    TransactionType::TendermintIBCTransfer { token_id: None }
                 } else {
                     TransactionType::StandardTransfer
                 },

mm2src/coins/tendermint/tendermint_token.rs

@@ -28,6 +28,7 @@ use keys::KeyPair;
 use mm2_core::mm_ctx::MmArc;
 use mm2_err_handle::prelude::*;
 use mm2_number::MmNumber;
+use primitives::hash::H256;
 use rpc::v1::types::Bytes as BytesJson;
 use serde_json::Value as Json;
 use std::ops::Deref;
@@ -95,6 +96,11 @@ impl TendermintToken {
         };
         Ok(TendermintToken(Arc::new(token_impl)))
     }
+
+    fn token_id(&self) -> BytesJson {
+        let denom_hash = sha256(self.denom.as_ref().to_lowercase().as_bytes());
+        H256::from(denom_hash.take()).to_vec().into()
+    }
 }
 
 #[async_trait]
@@ -513,9 +519,11 @@ impl MmCoin for TendermintToken {
                 internal_id,
                 kmd_rewards: None,
                 transaction_type: if is_ibc_transfer {
-                    TransactionType::TendermintIBCTransfer
+                    TransactionType::TendermintIBCTransfer {
+                        token_id: Some(token.token_id()),
+                    }
                 } else {
-                    TransactionType::StandardTransfer
+                    TransactionType::TokenTransfer(token.token_id())
                 },
                 memo: Some(memo),
             })
@@ -542,7 +550,7 @@ impl MmCoin for TendermintToken {
         Box::new(futures01::future::err(()))
     }
 
-    fn history_sync_status(&self) -> HistorySyncState { HistorySyncState::NotEnabled }
+    fn history_sync_status(&self) -> HistorySyncState { self.platform_coin.history_sync_status() }
 
     fn get_trade_fee(&self) -> Box<dyn Future<Item = TradeFee, Error = String> + Send> {
         Box::new(futures01::future::err("Not implemented".into()))