forked from jl777/SuperNET
-
Notifications
You must be signed in to change notification settings - Fork 117
feat(tendermint): staking queries #2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3376442
add delegations query support for Cosmos
onur-ozkan 217179a
add coverage for tendermint delegations_list
onur-ozkan f3db4c3
include rewards in delegations and impl undelegations
onur-ozkan 404b78b
add TODO
onur-ozkan 45f1a67
nit
onur-ozkan 77b8c63
extend the coverage on delegations and undelegations
onur-ozkan 7bcf533
handle empty reward case on delegations list
onur-ozkan d1115e8
keep the error with `MmError` wrapper
onur-ozkan 70b217f
handle tokens
onur-ozkan dff50c3
Merge branch 'dev' of github.com:KomodoPlatform/komodo-defi-framework…
onur-ozkan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is so much code in lp_coins.rs related to staking and delegation.
What about moving it to pub mod staking? The module can be inside the coins workspace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... I also hate that, but the thing is even with
stakingmodule in coins module it wouldn't be good enough, in fact, I think it will be even bad because it will look like we have duplicatedstakingmodules (one from tendermint and one from coins) and it will look inconsistent with how we handle other RPCs (right now they all included in lp_coins).I would prefer to re-write this module in general, rather than applying a workaround solution for specific logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can rename staking in tendermint or just add doc comment at the top of file
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I do it in this PR, it will be very hard for others to review this PR (due to moving lots of things around). I will wait for others opinion on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can create an issue to move staking code from lp_coins to its own module before adding more staking implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we should never do refactors that involves moving code around in the same PR as new functionalities.