Skip to content

fix(derive_key_from_path): check length of current_key_material #2356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shamardy merged 3 commits into from
Feb 13, 2025
Merged

fix(derive_key_from_path): check length of current_key_material #2356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
55c052d
fix(derive_key_from_path): check length of current_key_material
DeckerSU Feb 12, 2025
fa6326a
move length check to master_node, instead of current_key_material
DeckerSU Feb 13, 2025
6efbcda
fix fmt
shamardy Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mm2src/crypto/src/key_derivation.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,12 @@ pub(crate) fn derive_keys_for_mnemonic(

/// Splits a path into its components and derives a key for each component.
fn derive_key_from_path(master_node: &[u8], path: &str) -> MmResult<[u8; 32], KeyDerivationError> {
if master_node.len() < 64 {
return MmError::err(KeyDerivationError::InvalidKeyLength);
}

let mut current_key_material = master_node.to_vec();

for segment in path.split('/').filter(|s| !s.is_empty()) {
let mut mac = HmacSha512::new_from_slice(&current_key_material[..32])
.map_err(|_| KeyDerivationError::HmacInitialization)?;
Expand Down