Skip to content

fix(foot-shooting): remove leftover code that panics via RPC #2270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shamardy merged 2 commits into from
Nov 8, 2024
Merged

fix(foot-shooting): remove leftover code that panics via RPC #2270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
400b452
remove sim_panic rpc
mariocynicys Oct 8, 2024
55d9cea
no cow needed
mariocynicys Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion mm2src/mm2_main/src/rpc/dispatcher/dispatcher_legacy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,6 @@ pub fn dispatcher(req: Json, ctx: MmArc) -> DispatcherRes {
"order_status" => hyres(order_status(ctx, req)),
"orderbook" => hyres(orderbook_rpc(ctx, req)),
"orderbook_depth" => hyres(orderbook_depth_rpc(ctx, req)),
"sim_panic" => hyres(sim_panic(req)),
"recover_funds_of_swap" => hyres(recover_funds_of_swap(ctx, req)),
"sell" => hyres(sell(ctx, req)),
"show_priv_key" => hyres(show_priv_key(ctx, req)),
Expand Down
31 changes: 0 additions & 31 deletions mm2src/mm2_main/src/rpc/lp_commands/lp_commands_legacy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ use mm2_net::p2p::P2PContext;
use mm2_number::construct_detailed;
use mm2_rpc::data::legacy::{BalanceResponse, CoinInitResponse, Mm2RpcResult, MmVersionResponse, Status};
use serde_json::{self as json, Value as Json};
use std::borrow::Cow;
use std::collections::HashSet;
use uuid::Uuid;

Expand Down Expand Up @@ -259,36 +258,6 @@ pub async fn stop(ctx: MmArc) -> Result<Response<Vec<u8>>, String> {
Ok(try_s!(Response::builder().body(res)))
}

pub async fn sim_panic(req: Json) -> Result<Response<Vec<u8>>, String> {
#[derive(Deserialize)]
struct Req {
#[serde(default)]
mode: String,
}
let req: Req = try_s!(json::from_value(req));

#[derive(Serialize)]
struct Ret<'a> {
/// Supported panic modes.
#[serde(skip_serializing_if = "Vec::is_empty")]
modes: Vec<Cow<'a, str>>,
}
let ret: Ret;

if req.mode.is_empty() {
ret = Ret {
modes: vec!["simple".into()],
}
} else if req.mode == "simple" {
panic!("sim_panic: simple")
} else {
return ERR!("No such mode: {}", req.mode);
}

let js = try_s!(json::to_vec(&ret));
Ok(try_s!(Response::builder().body(js)))
}

pub fn version(ctx: MmArc) -> HyRes {
match json::to_vec(&MmVersionResponse {
result: ctx.mm_version.clone(),
Expand Down