fix(test): improve log wait condition to fix taker restart test#2125
Merged
fix(test): improve log wait condition to fix taker restart test#2125
Conversation
dimxy
changed the title
shamardy
approved these changes
May 23, 2024
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Jun 17, 2024
* dev: fix(indexeddb): window usage in worker env (GLEECBTC#2131) feat(tx-history): handle encoded transaction values (GLEECBTC#2133) fix(core): tendermint withdraws on hd accounts (GLEECBTC#2130) fix(core): improve validation rules for table names (GLEECBTC#2123) fix(test): improve log wait condition to fix taker restart test (GLEECBTC#2125)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test test_taker_completes_swap_after_taker_payment_spent_while_offline sometimes fails, apparently due to too early taker stop, so it does not have time to send p2p message with taker payment data to the maker.
This fix improves the test log wait condition to ensure the p2p message is sent and only then taker stops.