Skip to content

fix(BCH): deserialize BCH header that uses KAWPOW version correctly#2099

Merged
shamardy merged 1 commit intodevfrom
fix-bch-header-kowpow
Apr 25, 2024
Merged

fix(BCH): deserialize BCH header that uses KAWPOW version correctly#2099
shamardy merged 1 commit intodevfrom
fix-bch-header-kowpow

Conversation

@shamardy
Copy link
Copy Markdown
Collaborator

@shamardy shamardy commented Apr 24, 2024

This PR fixes BCH block header deserialization by making it the same as BTC

@shamardy shamardy changed the title fix(BCH): Deserialize BCH header that uses KAWPOW version correctly fix(BCH): deserialize BCH header that uses KAWPOW version correctly Apr 24, 2024
@shamardy shamardy requested a review from borngraced April 24, 2024 01:23
borngraced
borngraced approved these changes Apr 24, 2024
View reviewed changes
Copy link
Copy Markdown

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shamardy shamardy merged commit 38d328e into dev Apr 25, 2024
@shamardy shamardy deleted the fix-bch-header-kowpow branch April 25, 2024 09:34
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request Apr 29, 2024
Merge branch 'dev' into burn-dex-fee-for-non-kmd
bc5c005 
* dev:
  docs(README): remove outdated information from the README (GLEECBTC#2097)
  fix(sia): fix sia compilation after hd wallet PR merge (GLEECBTC#2103)
  feat(hd_wallet): utxo and evm hd wallet and trezor (GLEECBTC#1962)
  feat(sia): initial Sia integration (GLEECBTC#2086)
  fix(BCH): deserialize BCH header that uses KAWPOW version correctly (GLEECBTC#2099)
  fix(eth_tests): remove ETH_DEV_NODE from tests (GLEECBTC#2101)
dimxy pushed a commit to dimxy/komodo-defi-framework that referenced this pull request May 9, 2024
Merge branch 'dev' into eip1559-gas-fee-estimate
9169bcb 
* dev:
  feat(app-dir): implement root application dir `.kdf` (GLEECBTC#2102)
  fix tendermint fee calculation (GLEECBTC#2106)
  update dockerfile (GLEECBTC#2104)
  docs(README): remove outdated information from the README (GLEECBTC#2097)
  fix(sia): fix sia compilation after hd wallet PR merge (GLEECBTC#2103)
  feat(hd_wallet): utxo and evm hd wallet and trezor (GLEECBTC#1962)
  feat(sia): initial Sia integration (GLEECBTC#2086)
  fix(BCH): deserialize BCH header that uses KAWPOW version correctly (GLEECBTC#2099)
  fix(eth_tests): remove ETH_DEV_NODE from tests (GLEECBTC#2101)
  feat(coin): support nucleus as an alternative to iris HTLC (GLEECBTC#2079)
@cipig
Copy link
Copy Markdown

cipig commented Jun 6, 2024 •
edited
Loading

guess we need this change for XEC too, also a BTC fork
did a swap which was successful on maker, but taker failed to spend XEC makerpayment with taker_swap:1803] mm2src/coins/utxo/utxo_common.rs:2056] "utxo_common:1186] utxo_common:1139] rpc_clients:2378] UnexpectedEnd"
taker used 2.0.0-beta_b0fd99e, without this PR, maker used 2.1.0-beta_2e21532, including this PR
this was the XEC makerpayment:

         "event" : {
            "data" : {
               "tx_hash" : "8ca5ff9fb6ce25e157c5551891ef328c2e703ae067f69e99db55a4a2788c1b65",
               "tx_hex" : "01000000019944d49dc7c310170d2d81061aef05c2021ae0d146b2605e6452f459612650c5020000006a47304402205b06478a4d8f9f40b10989382013eed41dc2bcbf53d681e03ab17b860c514c780220749cbc7803b697f4af98bc5d4ec7f0e3bd9d3f015a4a768f023f4b088ba01b194121025d81c96aa4269c5946c0bd8dad7785ae0f4f595e7aea2ec4f8fe71f77ebf74a9ffffffff03118d4d000000000017a9142b81edd1fb7bc724729d4eabc5a3052c6f674841870000000000000000166a14e57dc769d6790a871e1707be6f4b5aa780a0aeedce1d0b01000000001976a914793634de8c88ec851b4b595f2f87a2071ae79c5b88ac80b56166"
            },
            "type" : "MakerPaymentSent"
         },

and this one is likely the same, on NMC: #2048

@shamardy shamardy mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@borngraced borngraced borngraced approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shamardy @cipig @borngraced