Merged
Conversation
shamardy
reviewed
Apr 12, 2024
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Thanks for the fix! only one comment!
dimxy
pushed a commit
to dimxy/komodo-defi-framework
that referenced
this pull request
Apr 16, 2024
* dev: fix(tests): fix failing tests (GLEECBTC#2085) fix(wasm): websocket url validation (GLEECBTC#2096) deps(zcoin): use librustzcash that uses the same `aes` version as mm2 (GLEECBTC#2095)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test kept failing because If you give a partial or incomplete URL to the WebSocket::new constructor, the browser tries to fix it by adding it to the current page's web address.
For our test case,
Websocket::new("invalid address")will return this URLws://127.0.0.1:52732/invalid%20addressas the webpage is being hosted on my pc using port52732.https://github.com/KomodoPlatform/komodo-defi-framework/blob/f0b21dccacb846510e2eb8f2150b1fd02fffd9dd/mm2src/mm2_net/src/wasm/wasm_ws.rs#L782-L795