Skip to content

feat(adex-cli): secure connection provided#1910

Merged
shamardy merged 12 commits intodevfrom
1873-adex-cli-https
Aug 2, 2023
Merged

feat(adex-cli): secure connection provided#1910
shamardy merged 12 commits intodevfrom
1873-adex-cli-https

Conversation

@rozhkovdmitrii
Copy link
Copy Markdown

@rozhkovdmitrii rozhkovdmitrii commented Jul 11, 2023 •
edited
Loading

Dependency updates

Package From To Compare mm2 Cargo.lock
core-foundation NEW 0.9.3 not present
openssl-probe NEW 0.1.5 not present
rustls-native-certs NEW 0.6.3 not present
rustls-pemfile NEW 1.0.3 not present
schannel NEW 0.1.22 not present
security-framework NEW 2.9.1 not present
security-framework-sys NEW 2.9.0 not present

@rozhkovdmitrii rozhkovdmitrii self-assigned this Jul 11, 2023
@onur-ozkan onur-ozkan changed the title feat(adex-cli): sucure connection provided feat(adex-cli): secure connection provided Jul 11, 2023
@rozhkovdmitrii rozhkovdmitrii marked this pull request as ready for review July 11, 2023 18:34
@rozhkovdmitrii rozhkovdmitrii linked an issue Jul 11, 2023 that may be closed by this pull request
implement secure (https) tcp connection in adex-cli #1873
Closed
@onur-ozkan onur-ozkan requested review from artemii235 and removed request for onur-ozkan July 11, 2023 19:19
borngraced
borngraced reviewed Jul 13, 2023
View reviewed changes
borngraced
borngraced previously approved these changes Jul 13, 2023
View reviewed changes
Copy link
Copy Markdown

@borngraced borngraced left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work. just one grammar correction and the rest looks good to me

@rozhkovdmitrii rozhkovdmitrii requested review from shamardy and removed request for artemii235 July 17, 2023 18:45
Merge branch 'dev' into 1873-adex-cli-https
b1b67c2 
# Conflicts:
#	mm2src/adex_cli/src/tests/mod.rs
shamardy
shamardy previously approved these changes Jul 26, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shamardy shamardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Only one non-blocker.

@rozhkovdmitrii rozhkovdmitrii requested a review from shamardy August 2, 2023 05:21
@shamardy shamardy merged commit 867a01a into dev Aug 2, 2023
@shamardy shamardy deleted the 1873-adex-cli-https branch August 2, 2023 23:19
@shamardy shamardy mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shamardy shamardy shamardy approved these changes

@borngraced borngraced Awaiting requested review from borngraced

Assignees

@rozhkovdmitrii rozhkovdmitrii

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implement secure (https) tcp connection in adex-cli

3 participants

@rozhkovdmitrii @shamardy @borngraced