test(new-flag): run all tests ignoring the failed ones#1907
Merged
onur-ozkan merged 2 commits intodevfrom Jul 14, 2023
Merged
Conversation
onur-ozkan
changed the title
Signed-off-by: ozkanonur <work@onurozkan.dev>
onur-ozkan
force-pushed
the
disable-fail-fast-on-test
branch
from
c39822a to
d7c21d4
Compare
shamardy
reviewed
Jul 14, 2023
Collaborator
shamardy
left a comment
shamardy
left a comment
There was a problem hiding this comment.
Just one question, shouldn't we add --no-fail-fast to cli tests too https://github.com/KomodoPlatform/komodo-defi-framework/blob/2966d832d086b0ad120596f3adab91e58499776e/.github/workflows/adex-cli.yml#L73
shamardy
approved these changes
Jul 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
self-explanatory